Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df2676f0e4dce565d483ce2149b2c54da05b34a5.camel@collabora.com>
Subject: Re: [PATCH v2] vcodec: mediatek: add check for NULL for
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Anastasia Belova <abelova@astralinux.ru>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     Tiffany Lin <tiffany.lin@mediatek.com>,
        Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
        Yunfei Dong <yunfei.dong@mediatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, lvc-project@linuxtesting.org
Date:   Thu, 03 Nov 2022 12:17:17 -0400
In-Reply-To: <20221102121027.4285-1-abelova@astralinux.ru>
References: <20221102121027.4285-1-abelova@astralinux.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Le mercredi 02 novembre 2022 =C3=A0 15:10 +0300, Anastasia Belova a =C3=A9c=
rit=C2=A0:
> Any time calling vp9_is_sf_ref_fb we need fb !=3D NULL after checks.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: f77e89854b3e ("[media] vcodec: mediatek: Add Mediatek VP9 Video De=
coder Driver")

As Angelo said, this change is a no-op in practice, for this reason I would
suggest to drop the `Fixes` tag (not worth the effort of back-porting this)=
.

>=20
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c b/=
drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> index 70b8383f7c8e..776468cd834a 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> @@ -208,6 +208,9 @@ static bool vp9_is_sf_ref_fb(struct vdec_vp9_inst *in=
st, struct vdec_fb *fb)
>  	int i;
>  	struct vdec_vp9_vsi *vsi =3D inst->vsi;
> =20
> +	if (!fb)
> +		return true;
> +
>  	for (i =3D 0; i < ARRAY_SIZE(vsi->sf_ref_fb); i++) {
>  		if (fb =3D=3D &vsi->sf_ref_fb[i].fb)
>  			return true;