Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1853187rwi; Thu, 3 Nov 2022 09:46:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6C7W8cseKH1GkQo/0AlRu4WYaQ5Ar2q8V5baWFmsA0gFgOC1s4XeY860EiJrhDmzky44sR X-Received: by 2002:a17:906:7948:b0:7ac:d6f9:eb3e with SMTP id l8-20020a170906794800b007acd6f9eb3emr29223902ejo.350.1667493990004; Thu, 03 Nov 2022 09:46:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667493989; cv=none; d=google.com; s=arc-20160816; b=rWdEOkEgPIJk6HNOSSbJ1qXr3AcgJh92RE3VKOZ0g6u4lOm4q5n086R4TNGeo2eoUI 2SPGVUE8UIePWzCpN4LZ3eGn2HdCuNmDbG6XmIqxOPx2kcShR0dET/psG6alCNw7vlxn zytDxSGRWwsxA5PVboSo4IxUUdrxN+QYchaeQDKwas7l95lH82enfZXz5zIxsfsqY53E /gpEJFu9HR8rtRo0emwEYiDdWVZ8EJd/fkaYXjoKFPSvC431r8fe3QOXFZ+7UJ80qqI3 tnLFWaUukFFd6/x585DfCvfF809ar3jW1fZHeI/DERpjKBzzftmq1G0sBNa0STR16t2k wEag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5PQSGj46emORhgqUGtr0hTIjmIvlY1AkXmhC02LCPAA=; b=HWEPNLkMEt3tdIWjn0pedV8vV0FOtHbIpJJZloMDWaacb4sJsBC6oxfqcif79khF5h Vnul6d8J4yuRcmfMgCCvLXgMToGVO+r8nC62YS6zerBkFjwbb85oFYynF5l0J2kvfmTY hC57VfXSl8ojo4g44RIFoaY9nk0NVduPfsKAU/ST92vV3uSH6e6s8lsPkGU+B2vO/eYa hEiOqrlnqrBNCrTb3KVIp1VOAEPlqMQIpIl9ogiRof+XWJn4cz69PdOrZ8iEeF2CA2rs 0vezlUb6mLLr+jzj+Ep4K+uSbfnG3CuoOhMjZ/8NcMv4dUaKG/Mg73TwqcgN6VgtRVOS KOzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gmwmoIZ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020aa7d610000000b004610f91a242si1692701edr.300.2022.11.03.09.46.05; Thu, 03 Nov 2022 09:46:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gmwmoIZ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbiKCQbH (ORCPT + 97 others); Thu, 3 Nov 2022 12:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232032AbiKCQaw (ORCPT ); Thu, 3 Nov 2022 12:30:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD2C18392; Thu, 3 Nov 2022 09:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5PQSGj46emORhgqUGtr0hTIjmIvlY1AkXmhC02LCPAA=; b=gmwmoIZ2h1Xz9z9c9NybrgM2bl PivdbbtviFzLY3YDWmixp1SdgarKlthl/De5brg2Vv8wH9CpzxHighzFfPfOsOand50+W3Kfp6Dw0 is+TuL+R/vZisl2uucsH1N2L/iYPsIjYM6dt42PPcMnIPfcWdXOsb7DZLmmTwOj894wRDryxdKlWC s7L57HT3NwJ4GnMxDjFZUSSeXJW/PllNIq0sUj7bH37Ae+NymznwohCjhAECS8wn5kzD7/Qs2+3s2 AVu69TV/nqh9/uoMIMzcY16a3ChjXSaO5VToiac0sI/D4oATurt5OXSKkGA/+h+fML1WishsdWiZT nAe4PhlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqd73-006bLA-1d; Thu, 03 Nov 2022 16:30:41 +0000 Date: Thu, 3 Nov 2022 16:30:40 +0000 From: Matthew Wilcox To: Keith Busch Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Keith Busch , Christoph Hellwig , Chaitanya Kulkarni , "Darrick J . Wong" , Bart Van Assche Subject: Re: [PATCHv2] iomap: directly use logical block size Message-ID: References: <20221103154339.2150274-1-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103154339.2150274-1-kbusch@meta.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 08:43:39AM -0700, Keith Busch wrote: > From: Keith Busch > > Don't transform the logical block size to a bit shift only to shift it > back to the original block size. Just use the size. > > Cc: Christoph Hellwig > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Darrick J. Wong > Reviewed-by: Bart Van Assche > Signed-off-by: Keith Busch Reviewed-by: Matthew Wilcox (Oracle)