Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1979502rwi; Thu, 3 Nov 2022 11:10:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4yUlJRJOhj9Ia4XS2utHlMbuRpqFBVV1Fc8LmkDHtJot0Rf++jQB1a9YPtPdyGXT+bvjmH X-Received: by 2002:a17:906:79d8:b0:7ad:b675:f34d with SMTP id m24-20020a17090679d800b007adb675f34dmr27519450ejo.194.1667499010956; Thu, 03 Nov 2022 11:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667499010; cv=none; d=google.com; s=arc-20160816; b=RjcId7hOCZSrcuyhKdJtjvPZQkF7W1hn0jhKO2ljqFAEdwyr4qbkxx+CsdMWI9odgs 2KU/bLB6n5sdY0Lt/Fz2iubW05r7HyDIwD6aZ1xpU3phuefmSBPCA7T+PDDi5WtoOSKc MSH4L4KPYbXU2NzixPBUzd9dBWkobtSpuT9LR1Ox2qlkaxgcfUc+fJORANkDUeZl9L8j huRV2+PcGhOEbO3KQVYuq8HoE5HApFMORWRWxcVAntvEX2pEXl5KXZL18ta7WOuPuVXA 3/xYthDMdkNM4RCIQVw58MH8gB9h+M8yTMofNoW0JLIYxmKbclFTxdfkd29Lx12KbAnH vUjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=8f8dJb7CmxUii0k7ReZbO/xecf8YvrxT0ueHHyma1BU=; b=mXOFKvKN0alnjhR0zdo7x2tY8vx4KNy8GaS8OsAXK/vMYFQZ/rS/9PRvw0n//3Qiw4 pfPumGDrlo529IWjULnUJoI9EJkhnjlZKWDVYLjQalnLJofBi6CxVdul8gx0zYWZJwtn l5CXCmKT2Y+P8al9TGrdu3TLXod88aB5TuOOVA5ozZray9ZhEOh+criRgabp0oPaSu7O 1Vs0CDOpAzkAxdp1Na3aF94rwfJPrzId65PLQDjYJRgL5Ha/2NuXAKQF1of68ftCTw39 UAe8tK2gSb8jyRRd+p5SEehI97m96smFjFtDUPoMKL8D1MAq3/NCk9CNGmh+1Kdiyi+P N2lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=D28rs6T8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a056402190a00b004593895fb89si2340432edz.390.2022.11.03.11.09.29; Thu, 03 Nov 2022 11:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=D28rs6T8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231477AbiKCRsw (ORCPT + 97 others); Thu, 3 Nov 2022 13:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231715AbiKCRsU (ORCPT ); Thu, 3 Nov 2022 13:48:20 -0400 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F0A1C13C for ; Thu, 3 Nov 2022 10:47:51 -0700 (PDT) Received: by mail-pf1-x449.google.com with SMTP id cw4-20020a056a00450400b00561ec04e77aso1059765pfb.12 for ; Thu, 03 Nov 2022 10:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8f8dJb7CmxUii0k7ReZbO/xecf8YvrxT0ueHHyma1BU=; b=D28rs6T8OGKqTwv+0w2tiy+Wo2uFgszomXWqOdz4bK8oHd/bxnx+ygDF11Merktoeh W0x/tTWAy+1K4R3PBvAmW6StBWEh4cu44wlQ5LyUHpThEqN8JyKhrY2ReJcTBvWxXctN c7p7B7aknkrGsUM+sQ8VoC51Ja99SE9d0zKTb0LZRMMyqsZV+Hcc3tWGzdC8Cx4BaYXj Q9CwKe+1CpuIX73dKrvuIkNUu0j8EPQ5Pg5VIsESR4Ixa3K6vFdcHCYbaKvgxXFV59jb j2jy2YJh6CyY4ElDHkYBrbjJLVuqzKlskpFuivE9C34VpXsmDwdCPXTY88fXmz/gLC1t qn0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8f8dJb7CmxUii0k7ReZbO/xecf8YvrxT0ueHHyma1BU=; b=kN7ojaO2P9aOiDsaJUU8rY0vAmrlWchd3/l5/MujteGT3y90MuMR61m+Rj5W6EOrTH m3zKZOLy7YZpZp3dbRyYHvmvn5oeqZbxkipiV4bODLgD9UOcCJRCB5KQGvGa652X/dNK /Z14/YVoR0rr1cXhwxRfu3ZOkAdXkZYKR2j4XBS0SIxa5bioUS9KOLfQhmaYrm+VU+eG 5DajP7SBMHwe+AqTYDbyCCWWaqJP2qbghu/+gmv94wnNDcATkjYh0V8g7pnNcWK+Mrwv 0KEMMW5U9G1fh6oBPzpLO0ZLb69ABA1FVmkyZNjFjZNVFTN3/qtWS4XVYM3mo+cBhB5L tjvw== X-Gm-Message-State: ACrzQf01m6fXaWKZo8XGVMpZupnmVqCeNpsIHMTS3tmXdGR2mJu5r2pQ lkFBcYRAuqu39kWv3JnACpmz8J+yS8S3jg== X-Received: from dlatypov-spec.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3f35]) (user=dlatypov job=sendgmr) by 2002:a17:90b:4c8a:b0:214:2ed8:6501 with SMTP id my10-20020a17090b4c8a00b002142ed86501mr9877245pjb.70.1667497671335; Thu, 03 Nov 2022 10:47:51 -0700 (PDT) Date: Thu, 3 Nov 2022 10:47:40 -0700 In-Reply-To: <20221103174740.3492603-1-dlatypov@google.com> Mime-Version: 1.0 References: <20221103174740.3492603-1-dlatypov@google.com> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221103174740.3492603-3-dlatypov@google.com> Subject: [PATCH v2 3/3] kunit: tool: remove redundant file.close() call in unit test From: Daniel Latypov To: brendanhiggins@google.com, davidgow@google.com Cc: rmoar@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, Daniel Latypov Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We're using a `with` block above, so the file object is already closed. Signed-off-by: Daniel Latypov Reviewed-by: David Gow --- v1 -> v2: just rebased onto linux-kselftest/kunit --- tools/testing/kunit/kunit_tool_test.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index 5e3429a1202b..90c65b072be9 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -242,8 +242,6 @@ class KUnitParserTest(unittest.TestCase): self.assertEqual( "example", result.subtests[1].name) - file.close() - def test_ignores_prefix_printk_time(self): prefix_log = test_data_path('test_config_printk_time.log') -- 2.38.1.431.g37b22c650d-goog