Message-ID: <46B6F22E.1020300@csr.com>
Date: Mon, 06 Aug 2007 11:04:30 +0100
From: David Vrabel <david.vrabel@csr.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20070604)
MIME-Version: 1.0
To: Pierre Ossman <drzeus-list@drzeus.cx>
CC: linux-kernel@vger.kernel.org
Subject: Re: sdio: set the functions' block size
References: <11858961933491-git-send-email-david.vrabel@csr.com>	<1185896193612-git-send-email-david.vrabel@csr.com> <20070804153040.73668e4e@poseidon.drzeus.cx>
In-Reply-To: <20070804153040.73668e4e@poseidon.drzeus.cx>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1216
Lines: 33

Pierre Ossman wrote:
> On Tue, 31 Jul 2007 16:36:32 +0100
> David Vrabel <david.vrabel@csr.com> wrote:
> 
>> Prior to calling the driver's probe(), set the functions' block size
>> to the largest that's supported by both the card and the driver.
>>
>> Signed-off-by: David Vrabel <david.vrabel@csr.com>
>>
> 
> Why a maximum size for the driver?

For efficient use of the bus it is useful to pad transfers to a multiple
of the block size.  I reckoned it was potentially beneficial for drivers
to use smaller blocks so less padding was required.  However, after
looking at some figures the per block overhead (28 clocks for a write)
really does limit the transfer sizes where small block sizes is beneficial.

I'll remove this.  Drivers can still override the block size by calling
sdio_set_block_size() directly.

David
-- 
David Vrabel, Software Engineer, Drivers group  Tel: +44 (0)1223 692562
CSR plc, Churchill House, Cambridge Business Park, Cowley Road, CB4 0WZ


.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/