Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00d3b2e3-6c93-0e48-e87b-ebd9c6574e00@seco.com>
Date:   Thu, 3 Nov 2022 15:07:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] net: fman: Unregister ethernet device on removal
Content-Language: en-US
To:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc:     Madalin Bucur <madalin.bucur@nxp.com>, linux-kernel@vger.kernel.org
References: <20221103182831.2248833-1-sean.anderson@seco.com>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20221103182831.2248833-1-sean.anderson@seco.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFJGcWpLcVRIa2ViWDI0UWdlcUlIUUNRaE1TOUtyVWdob09HTWxORGJVQURs?=
 =?utf-8?B?MkpMdlo2d2p2ZXUzQ2E4KzNxVEcxa0g1dHJXVHNnT0pDVDJ4bEFMcUN2QmhN?=
 =?utf-8?B?UHNsQndHNXpOVDNEc2c5Nmt3akVTUHI4bVJ0Z2tmRDNYcEJzL01ZTmlCb0Rr?=
 =?utf-8?B?UFN6cEN4NmtPbXZsc2kzU1k0aFplTkFTZnJSbUNzNWV6QkFEaDRZd3dXV1Zo?=
 =?utf-8?B?TE15ejlwdXNqRzNKRGlBbmZsSzlqQ0pWNkVKM3AranlxaHFyNG5rOElvM25X?=
 =?utf-8?B?bVdRRmRNZ2Iwak1wSjMzbERyb2xlRmtHak1vaktMUXhiaUV1M05VYjdlNngw?=
 =?utf-8?B?bFM5bmRBTDFvN1Q3UDdUNHJxN0doZnoyT0xHOC8vay82YVN3SklodE5JRDdS?=
 =?utf-8?B?Q2NKL1NVWE40clpIZVhhaFJoaHNReHkwa1ZVUDBad0xmQkNPemZPOGtOU1JL?=
 =?utf-8?B?eTBWbTlTSGlWYlpIQVo1bTNndTVDR20rS3JFZmpBSmJENDVPOGNOM05YbnJ0?=
 =?utf-8?B?S2dWektyYnI5eG1pR0d6b2ZBRkQvUHg1VnI4ZGtOMzUwSWR1TUFubEw4NEYy?=
 =?utf-8?B?SUpKeVBCT2Q5SjRxeitRSVpISkRGNnBCb2ZtNlE4aWEvSml2VUhIQ3A0RVN0?=
 =?utf-8?B?enlHWWJIajlrdVRGTWxrUTd2VHEzTm9IL0hqZ1g4YmhlMXNRVHhxaFBLeWt3?=
 =?utf-8?B?cTR5YkFYS2dNS3QzQVYvZUlJRHJvS0FiR3JnT2I3VEt4ZkFvWm9RWWVoVGlS?=
 =?utf-8?B?Sm5OTVpIM0l4ZWIwei9Xc0o5MmZHVnlaVVlxWGRVM3djQWVHLzFYRVA0SFBP?=
 =?utf-8?B?dFJITHMvV3g3UW9TV3Fsc1QySUdMZlg1SUIzZ080UElpWTFNQmRBd3Q3MlI5?=
 =?utf-8?B?U0ZkTnNBOEtsZUJHcHFOekwrNk5QUSt0b1l2UVJOWWxyYkFGdGV6RzRRbVdp?=
 =?utf-8?B?WGpFUHdJU3dPWE9YdG8wK0ZmbTh5VHEveVN3TjBMVmlYZWNMNEs3em9qQmg2?=
 =?utf-8?B?WWhKYWRIZmhSRGJFbHNqV2ZmT1JJcEdOOFBTbnU4THkwNFBXbEdxWFovMTRY?=
 =?utf-8?B?RDZIaGlmNnZGY0s5SGJhWS9mUUdQNWVYNW5zaUdqaFZqbFdEdTlqZU5NWWdQ?=
 =?utf-8?B?VnpuckFTV256T25hVFBlQmJ2VUlja2NLZ3o3dlFzbFpUbUdnWm9PcWROcXY2?=
 =?utf-8?B?aWhOZFllYzJPQjlwSkNRdDdYM2dvWXRmcDhEQnBseng5aXFaMDJZOU05ZEJn?=
 =?utf-8?B?bHhnemZqcW1PWUhtNnM1c0ltR1V3dXZDQVBiN29Fa1Fiem5QR1JSSGE5ZEVZ?=
 =?utf-8?B?TWZhSjlLVG9IaldWQkRJTzV1dll5djQzLy83WmkrUmpiU0xVRDI5YWg5TmVk?=
 =?utf-8?B?RUs1UXVqWWZ2WGZJdVVHMi9tRTZYWWxueEd5TDlLUS83OEZiS09SMHRvZEFU?=
 =?utf-8?B?Y2p3dC91VDRyZVB1RkdMSjBCTDg3Y2tvRXg4c0psN3Rqb016VW9hN0kxbCtn?=
 =?utf-8?B?Nno1cmhSWVdyVnRtZ3BvRzcrZHpRUi9ZN05HbUFkWGs4WjREMDZFRjk3SXVM?=
 =?utf-8?B?Q1hHZ2RXZU9jTGZVcnZUMGtRbWdiQm1Rd1dySmtkWjd5Mng5SmNmdXAvekVM?=
 =?utf-8?B?K0xJWUtodlU0cnpFWTJjd21KMmp6RGRORlIrNkdJckdMYUc5RFZ3NVRqeWZa?=
 =?utf-8?B?RkxVTVc1WTB3VTQrT0x6M0ZDQUNvdFkxdmVxOGlCWE16M2lsMjBWWmg1Tkpp?=
 =?utf-8?B?UlZ4Q3AvaDBwYVpQbkpOYWZlaVJuNDBjM2hBN08vUTlOeW1GQUlSVVB3a2lY?=
 =?utf-8?B?bEF4ODhRbkVBcTJBTzcvRHg3RjBLMzVkdFY3QVpqZ1lPRmtxamNZSU91M2oz?=
 =?utf-8?B?UFhmOHhEOC9QMENNMmI2UHk5SUtNUGlaM3gxQWJYU3ROYSs1NDRSM1pZUzdZ?=
 =?utf-8?B?bGJMZ2UvSHNaUS9sUFZQQ3JhaTNZUWljY3BTaDRNdVUwQnhrUGo2UTJCK0Vz?=
 =?utf-8?B?WklaY2QxeWhTTTV3NVZQZTMxMVIzMHdTdWp3VXB6YWJnQ2JPa21vNGFkaHhW?=
 =?utf-8?B?M0FHTE1KR2kxYTNZdUZ5RkhYZXRJbWtYT0J0UzB0QjlieVc2MjJHcFY2cnJo?=
 =?utf-8?B?cFRvSWJiZFFYd0Ira2hSL1BDMUVDVENBSkt6dXMxTzFscytDVHp0NGZ1QzdO?=
 =?utf-8?B?VGc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abc85213-a7e0-4efa-9059-08dabdce9e5c
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 19:07:14.5687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o5k8+ha3fLRaZJeXZ86n6sNr2TQk2yXfHacNPnCIrbThYIgwQc718q9XGkAurshCDS7FtxPp8DILcP/upkHDpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB8397
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/3/22 14:28, Sean Anderson wrote:
> When the mac device gets removed, it leaves behind the ethernet device.
> This will result in a segfault next time the ethernet device accesses
> mac_dev. Remove the ethernet device when we get removed to prevent
> this. This is not completely reversible, since some resources aren't
> cleaned up properly, but that can be addressed later.
> 
> Fixes: 3933961682a3 ("fsl/fman: Add FMan MAC driver")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
> So... why *do* we have a separate device for the ethernet interface?
> Can't the mac device just register the netdev itself?
> 
>  drivers/net/ethernet/freescale/fman/mac.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
> index 65df308bad97..13e67f2864be 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.c
> +++ b/drivers/net/ethernet/freescale/fman/mac.c
> @@ -487,12 +487,21 @@ static int mac_probe(struct platform_device *_of_dev)
>  	return err;
>  }
>  
> +static int mac_remove(struct platform_device *pdev)
> +{
> +	struct mac_device *mac_dev = platform_get_drvdata(pdev);
> +
> +	platform_device_unregister(mac_dev->priv->eth_dev);
> +	return 0;
> +}
> +
>  static struct platform_driver mac_driver = {
>  	.driver = {
>  		.name		= KBUILD_MODNAME,
>  		.of_match_table	= mac_match,
>  	},
>  	.probe		= mac_probe,
> +	.remove		= mac_remove,
>  };
>  
>  builtin_platform_driver(mac_driver);

err, this should be [PATCH net]. Sorry, will fix if necessary for a v2.

--Sena