Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763923AbXHFK7y (ORCPT ); Mon, 6 Aug 2007 06:59:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752444AbXHFK7r (ORCPT ); Mon, 6 Aug 2007 06:59:47 -0400 Received: from mail-gw3.sa.ew.hu ([212.108.200.82]:56191 "EHLO mail-gw3.sa.ew.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbXHFK7q (ORCPT ); Mon, 6 Aug 2007 06:59:46 -0400 To: ioe-lkml@rameria.de CC: miklos@szeredi.hu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org In-reply-to: <200708041341.16231.ioe-lkml@rameria.de> (message from Ingo Oeser on Sat, 4 Aug 2007 13:41:15 +0200) Subject: Re: [patch 03/11] fuse: add reference counting to fuse_file References: <20070803174425.998083527@szeredi.hu> <20070803174918.484417699@szeredi.hu> <200708041341.16231.ioe-lkml@rameria.de> Message-Id: From: Miklos Szeredi Date: Mon, 06 Aug 2007 12:59:14 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 29 > On Friday 03 August 2007, Miklos Szeredi wrote: > > From: Miklos Szeredi > > > > Make lifetime of 'struct fuse_file' independent from 'struct file' by > > adding a reference counter and destructor. > > What about using krefs to implement that? Thanks for the suggestion. I'm aware of kref, but I don't see the huge advantage over using the raw atomic interface. > This will also fix the missing smp_barriers, Why are the barriers needed? The documentation doesn't say anything about that. > is very simple, saves code, makes your life easier and is a well > known known kernel infrastructure :-) I think it saves one line, and adds another, for a total of zero lines saved ;) Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/