Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 12:03:05 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Zhao Liu <zhao1.liu@linux.intel.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthew Auld <matthew.auld@intel.com>,
        Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Nirmoy Das <nirmoy.das@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
        Zhenyu Wang <zhenyu.z.wang@intel.com>,
        Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 7/9] drm/i915: Use memcpy_from_page() in
 gt/uc/intel_uc_fw.c
Message-ID: <Y2QQaYBD1ECJDoNP@iweiny-desk3>
References: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>
 <20221017093726.2070674-8-zhao1.liu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221017093726.2070674-8-zhao1.liu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?anm4px1RBaIZOoFHJgPyNySczHrBFwjB958AcT0XnW+OGymcbDh9/Zc8xTSe?=
 =?us-ascii?Q?n8ayRtoXt4dTTD2p4WHFGeCZOjxiXDwjAm9/s6WGv3TGDvvlGAk9RKVNTios?=
 =?us-ascii?Q?VjuDLVckRBC6O4/A2cuTWWJz5JWvjTXzbEKVXfGT9o4MoM799E6PB/Vdypi5?=
 =?us-ascii?Q?ZwsveD/4teX7qWUKsy2v4Tzo7YO0r9J9gF1BUozUyAbtBsrUUfJk0evZIuf2?=
 =?us-ascii?Q?8DpLL5OT2aZBUtvu15YXIz/X2rxJF4cNvJTdiUKudhUjUOeJeciruxanib+g?=
 =?us-ascii?Q?xEmc6TwLMRJldZzyVAn2qPTeRC5KBsBMSemQ4IeA+4xd6nm6pEBRyxnLIzcK?=
 =?us-ascii?Q?GS4o7uFxTJyfov6DE0/P8gRZ1jBf/ZCmRFqfZ5HvtJ3H2EFpaw64GigxuOly?=
 =?us-ascii?Q?NHHNQlI2Hw4xgUhHEQmPNDvhXp71qh+2VwnsiVzLej74JivyMWRQFMjHJpW9?=
 =?us-ascii?Q?s64936nL9whrhWy0Xv47pAL9dkVYeZgOdM/GBVk3tnFWMGCRsi3HlIIRpIYF?=
 =?us-ascii?Q?34YYI0xSsVZiIJZS4n19n9BH5WveYkxwcSIYdV9bp8rL85mCqwZzMM2yrJgv?=
 =?us-ascii?Q?vxBQrejtpmAZfcKL4WekUZiy1FaZ5O0t9i7eXTX7s9rUfD2yqppwN6LMFTSu?=
 =?us-ascii?Q?G0M1B1IZdzc2gf+SvmXj2W0mIxouIR/Z/5u7Lhs8rm6ZUUlqAAUPrlYS0azM?=
 =?us-ascii?Q?BbrEhnonkkUBhPzsX2yfwG38pEvLUAG+7JdVsp21YYEvfWSAFkWT4XfHua0Z?=
 =?us-ascii?Q?m3koe3IP6qTyC7TcNS/hlBpZXR3osMWDw8+/C9WaCEjIwf424++n9iSnDnOf?=
 =?us-ascii?Q?STzS/H7cX685SxgnvJJ3fKPGZyafy3zmC0c1hio1gG0t9SmWqaqoW7hYP4iZ?=
 =?us-ascii?Q?DXuXok4VAqUzSBFRBN1XUJCa6lBLiTJSgfqPlsckah1Jv3pxopW06dJo2R+U?=
 =?us-ascii?Q?a3cWN2e1dFVpJGUMGB+I2rErnSGm/Q446WA+Q0TVLn3CoB/zzif+i/IaVQz1?=
 =?us-ascii?Q?1LmTBusSXwXR8dPXk/EGBIiblXox6Fj6NSBg3zYkSppO/yrZMqe2E56tSda/?=
 =?us-ascii?Q?7TbiwYD55PRAq/6ERmRTvigmzfFCa4Lp1hZ+gNDQFO0GJ4OCq/zxOnWj8GNp?=
 =?us-ascii?Q?WTxNUJcAj7FQuemQ0A+DloefW0QWICSoXHfPYHlCsFmUChvX4ROdQ92J8Qra?=
 =?us-ascii?Q?rQz6PbCFkHEaUus9JIUSnAs3PHXOR2zYILV48UNzMs81/qZwy2yUDtaJvXqz?=
 =?us-ascii?Q?dRtk+TJLFmCYiRk8/FYFGBGEDZAnH8L3zo1tY4CKDSvbjycPzeqcoYQCg3OX?=
 =?us-ascii?Q?w/0nwJ14ECY2ZFKua0cDVGL0Mf3mq5y5YN73OGtbCbp0RfigKPCD/m6THZCy?=
 =?us-ascii?Q?i2qXzxzaaifduJ2kBF9IlkcQ/9kDJ2z7vVQTmS2RKsbTQQT7tVQO4FBchRTa?=
 =?us-ascii?Q?RKOhqd3dt+qQiwvO32nWx6nNg1GrYPAwKNMBk1hHX6aYd4gCqWYwmiDsxUCb?=
 =?us-ascii?Q?Icb8AuqgtB0K0azKy6Axts3yUVg26p7roR88IngKO2OkVi87MAw6Y6fDKoAq?=
 =?us-ascii?Q?wJ2PpuidH6KHqCs5e26HKzshZeMcHAmbjE6NvDL4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 653220bb-fff7-4bc4-c58a-08dabdce0d52
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 19:03:11.2505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nUm+gF1rcD+u3owDyr/gwbL4ozc0tNZNYXHkvgUfAxXHeGnph5Bytnjy4rClmsHFtt754zef0n+cLuJmrseGEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5161
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 05:37:23PM +0800, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].
> 
> The main difference between atomic and local mappings is that local
> mappings doesn't disable page faults or preemption.
> 
> In drm/i915/gt/uc/intel_us_fw.c, the function intel_uc_fw_copy_rsa()
> just use the mapping to do memory copy so it doesn't need to disable
> pagefaults and preemption for mapping. Thus the local mapping without
> atomic context (not disable pagefaults / preemption) is enough.
> 
> Therefore, intel_uc_fw_copy_rsa() is a function where the use of
> memcpy_from_page() with kmap_local_page() in place of memcpy() with
> kmap_atomic() is correctly suited.
> 
> Convert the calls of memcpy() with kmap_atomic() / kunmap_atomic() to
> memcpy_from_page() which uses local mapping to copy.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/T/#u
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Suggested by credits:
>   Ira: Referred to his task document and suggestions about using
>        memcpy_from_page() directly.
>   Fabio: Referred to his boiler plate commit message.
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index b91ad4aede1f..64d56f175d32 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -962,16 +962,13 @@ size_t intel_uc_fw_copy_rsa(struct intel_uc_fw *uc_fw, void *dst, u32 max_len)
>  
>  		for_each_sgt_page(page, iter, uc_fw->obj->mm.pages) {
>  			u32 len = min_t(u32, size, PAGE_SIZE - offset);
> -			void *vaddr;
>  
>  			if (idx > 0) {
>  				idx--;
>  				continue;
>  			}
>  
> -			vaddr = kmap_atomic(page);
> -			memcpy(dst, vaddr + offset, len);
> -			kunmap_atomic(vaddr);
> +			memcpy_from_page(dst, page, offset, len);
>  
>  			offset = 0;
>  			dst += len;
> -- 
> 2.34.1
>