Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 12:25:32 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <tony.luck@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 07/14] x86/microcode/intel: Expose
 microcode_sanity_check()
Message-ID: <Y2QVrEGkfvpT/2KB@a4bf019067fa.jf.intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-8-jithu.joseph@intel.com>
 <Y2OnHuSHgIMGxcUH@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y2OnHuSHgIMGxcUH@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IPQgG4UNjdxJUZEpdsk6C2qMn9ZoPyi7OIm/Rp70moKQpJ5n+fKUPpKjNCns?=
 =?us-ascii?Q?5h0n7/gYHmOy267eT9aiKtteNQA6S2UhPQp5YhcyG8295L8J7UjpjE/ZNfLB?=
 =?us-ascii?Q?Kk7UyUAlVagVK8jU7McAPUeADM/UwVXgJdDal/zb8rtn+MfWw/+bQgshKLM5?=
 =?us-ascii?Q?89+qIPwmiO7AY2cC4s0nV+IAYrHJrzByBS4TER/obXLD4qTMbQzSpsWyAa0t?=
 =?us-ascii?Q?jQlqjFqDhQMQZX+h6HfqeZrO2G95kQTupq6lamih1zlaH50JgTZ1apQD4NlR?=
 =?us-ascii?Q?2boFt8+wH6dkVbzn6/vNjKElkYRF2ZaVpMCMv/Si3s8RXW1Jmcss9gqy6We0?=
 =?us-ascii?Q?AnhoCWMUOCfpvoib31xxxdEyMiVJtraHGdT54x7HtDrboWH/6tTJ9xMIU6uG?=
 =?us-ascii?Q?+LCJEQSogGKSGMBCgqoocHKHLmmlByo0ad3Ubcy6BCQRrFWEzXjgixYR3AA7?=
 =?us-ascii?Q?4d/XsDdDb63Y7nuzzJqgsRb8/WCwu+5flIPEiwKqHOaWJRNKmMm/DjfkIiVf?=
 =?us-ascii?Q?2tJMiBovTa7zJkgq11PERRYsO/eVS2iPTHhsSkuD/kOPFq2d2DFJ3TseGmy7?=
 =?us-ascii?Q?JhDryc3ZoxT9g5RV1P2KEheram3AXccOrv2eIlzEHZ7qgTU0j7Gqi4b4EH+s?=
 =?us-ascii?Q?P5gWuHEY499KoXrwMhoYf49sETztRhzTLxW1yAtX4oIt4DcFi0hDJOHbgulE?=
 =?us-ascii?Q?qVsnqiAb7x1QWTtm8NoP62aZdiZ7JrgYyrklJcjjZhLODXYTMwFxGoOfu/RD?=
 =?us-ascii?Q?uf7n0QrgNXhAzbeoesEkSQYQG06Uaynacl4eWHyp1LH/5xRjLxzuQq05SCzb?=
 =?us-ascii?Q?RsVpBIgN5Xm90GMZ9RVrVNUZI6ac6yEASqs7LGD+eu/df+tZpzRhaIrzyx5+?=
 =?us-ascii?Q?JnKvxADLUXDRwxIdIXVWILVplYzdojAp2m8PkQmcjstJh1eFjyXsFbUcR3sl?=
 =?us-ascii?Q?oZ7ZDlQFaz23/Nk5a8tK8B3a04DK5B0ZTChzbgn4rOpdshZ0Cs/MrjS7ONnw?=
 =?us-ascii?Q?jzTCN5aS5vLEYVGMiDdKAxQ0JLLA8Hz9wtsqW4e1WHf++z5oK9GOXzLFgPvP?=
 =?us-ascii?Q?z+zQXC/47BzvNwFOmoPOGgt5dG9oVuLb/liUkw+VFV48DH3ZaLHUExxpaeWn?=
 =?us-ascii?Q?y9/Iqau2u0RIw+VPMertE+Z6r5nGh3h1gt6jCNbXl29zHtZwskVzSFRnJLb6?=
 =?us-ascii?Q?noaE6D7Z8YrrdASEuumXPg5LL2ALiaUnA79Ihkw3aRv8kfTk0UsHi1myrQDp?=
 =?us-ascii?Q?lxv4HAKGJ9Z0nCxL55YEmda0LMv7ElX9f8I+PsSyX8uWpjvDdEBJPCvp1t+Z?=
 =?us-ascii?Q?bkC9Cvy8HByolbmY0PZ3/CbcDqrt7A2i6o3qeCzfWXgTixe4Utf6ckX1cSKv?=
 =?us-ascii?Q?K7izF21LbvDiQkfnH/LxG7Q7Q2YR1bIq1EQFs0XwP6Cvux2VuT7YwSjkwW+O?=
 =?us-ascii?Q?rWbmCgoqNJTc3QLj6cmS/YzAK6aqu+qE0lRwsEizOJHQWQLKJoitquPVJfpC?=
 =?us-ascii?Q?5ezPojRZu9fX0tnZ+WY8YI+dR7NRtbOjXsVAVEbN7C5gnM9xajVN0kkogFb+?=
 =?us-ascii?Q?dvwlpJnDQnHHTPmR96GrMTgQPwQF8Ie8safIQn+gbYUsjKumE+Ak/J/yVlAq?=
 =?us-ascii?Q?Bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec207bf0-e9c2-457a-30cb-08dabdd12eb2
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 19:25:35.7322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sW8rMTPR4LdLQXoWuewF6NltF+j1rJkDTUHARFnyFpovCnQo0BGRi8933UqFg22hqqXXux0Vy8/7iad5n9hVlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6242
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 03, 2022 at 12:33:50PM +0100, Borislav Petkov wrote:
> On Fri, Oct 21, 2022 at 01:34:06PM -0700, Jithu Joseph wrote:
> > IFS test image carries the same microcode header as regular Intel
> > microcode blobs. Microcode blobs  use header version of 1,
> > whereas IFS test images will use header version of 2.
> > 
> > microcode_sanity_check() can be used by IFS driver to perform
> > sanity check of the IFS test images too.
> 
> So I'm very sceptical about such reuse.

The generic parts of the microcode is completely common between IFS and CPU
microcode. The parts that differ are in the meta-data. 

CPU microcode has stayed the same for over 15 years roughly. Changing
formats isn't something that's done lightly especially since there is cost
of enabling in all OS's. 

Both are in the same class of microcode, consumed by the CPU. Inside Intel
the format change is also pretty strict that they have several levels of
approval within the HW teams and also needs review and approval from SW
teams.

What probably is best is that we should document that the external formats
are shared in the header and probably in the shared routines. Changing
names as you suggested to be more generic is in the right track.

> Then the testing burden won't be an issue and there won't be any
> potential cross-breakages.

Even if its only a few hundred lines of code, it seems odd to simply
duplicate for the sake of fear of testing.