Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad15b398-9069-4a0e-48cb-4bb651ec3088@meta.com>
Date:   Thu, 3 Nov 2022 14:21:26 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH bpf-next 2/3] bpf: Add bpf_perf_event_read_sample() helper
Content-Language: en-US
To:     Song Liu <songliubraving@meta.com>
Cc:     Jiri Olsa <olsajiri@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Martin Lau <kafai@meta.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
        Stanislav Fomichev <sdf@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
References: <20221101052340.1210239-1-namhyung@kernel.org>
 <20221101052340.1210239-3-namhyung@kernel.org> <Y2DuzmnUm6NIh25a@krava>
 <5b0152db-8a8e-0d8c-0304-8c48b735c3b7@meta.com>
 <CF3D88C5-4D62-48E2-97AB-F6A7FF9CEF9D@fb.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <CF3D88C5-4D62-48E2-97AB-F6A7FF9CEF9D@fb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEpITDY1YXFMV1Rhd1pjSGlRR3hvRU9pdGM5a0M0U3NCNEFBZHpQVGZTTGNz?=
 =?utf-8?B?dkZmS2c1T1FZRU9FWXFwWDVNMnpCRmYvSGl3SGVOanFlZTByVDVkNlVmSEtj?=
 =?utf-8?B?eUxkRFhKWTROKzViSUxPL2daRzFGTFQvN3lnZTNqU29sNHBLWnU3WTErNkw1?=
 =?utf-8?B?c01QdEtCNWRBUHRZWTRYRnJXcGNubW9zdEtENUxyUkJBTkgwbzlCYjliV1Rr?=
 =?utf-8?B?NEJ0eXFKNTNqZjdJRUc1NGNPMzFWQ2tZMDJlUURveE5lZ3lJMjlEM0h3Zk5U?=
 =?utf-8?B?cmtaQnhLOWY3UmdSMVJNWThXY05KMU9VeGpkVmpzbTV6bmNMbFB4bXNZbGIr?=
 =?utf-8?B?WFVTUHpWckxkV2JyenFXTHFkbit1bWh0ZktBWE84QWdMdVY3eC91a2NNL3Vj?=
 =?utf-8?B?YnhaK2FFVlpabTVsOWJwL1RaZHdXNlBQV1ZhYlZrWTkzRDQxQzdIaTFUbGk3?=
 =?utf-8?B?dTl4ZWczWjNId2I2WnQrQldpWVpZdnV3a3Z3RHBjMVpoSmhLTXZCQmRBMk4v?=
 =?utf-8?B?NE1sMlBkYUU4M0QzWWJOQktXMVpxdnlZTVBxTTlRNjdkSXhLQWc4eXRzblFI?=
 =?utf-8?B?RWFDR2NiTitTZG44dFVNN1gvRGhyeUdWRnRINkhnNHdyaC9GSnB3V1RLMk5j?=
 =?utf-8?B?M3ZDZDc3elVEdXlMSXJtVXFQVEIzSGVqZ0I1MGlUYXJ3RkNveEVHb1QyU2d0?=
 =?utf-8?B?ZEF0SEZMZURlK05JOE9id0I1WnRxbGlXa2hvVlRiRHRLQXQrc25Ld1h1YnZs?=
 =?utf-8?B?V2puQ0tVUjNVZXBaVkw4RTRMd1JST09tMnpzUkxQM0M2amRQVGhOK3JpRFN2?=
 =?utf-8?B?UmZjKzMrY3krUWYrQ2prVGRMNGE2ZFpuenpaTk5WaGlINWpacVR3Q05VYW82?=
 =?utf-8?B?Z0lwTWF5UTZXVjVwV09tK2ZkK1MzekZ5dGpoeGFMT2FyUm9TWVp5WThGa0o3?=
 =?utf-8?B?bzZTZzNMeVdSK2VjNExxc1FSdTFaN203Uzlpdmp3eEUwSzRSNzdWTlpLNk5B?=
 =?utf-8?B?MmQrR2Mzc0l3bTcyeDRLelJqT0owM2JsOGRWWDBTWVVaRXI0dG1SOE5RMnN1?=
 =?utf-8?B?TE9BWXVCRzBtSzRPWE1GTmNRZXNoWW9JNW1uVG8rN0NJejNKWXRBdnpLTmF0?=
 =?utf-8?B?c0VkVkxrMzVFREhsRTBtc0lDcGl0VDFNcDg3aEFTYUk5OEkvYXN1V0xiVG9l?=
 =?utf-8?B?LytGUHRLKytoSUxHK0lKTytBR2d5bkl6TzY0bkF0aHBlUWxhU2k4ekd3S3Bh?=
 =?utf-8?B?bEEwanIrZFNrdVRNczhTSjlsNHYvZkFDWDhNT3J3clIxWFlwTXVDV1A2azk4?=
 =?utf-8?B?bFJaeUgrWXlvajdLNmVzWmM5THFOb0NxeTJnZ3MyWDQzM0NtSWIzTnJWS1dP?=
 =?utf-8?B?L2lNUWF6a3NCdUF0WDE2WGF1ZEhFa2FtMXNnTEdLUXdpd2ZuOG9iZ1paL0Ro?=
 =?utf-8?B?OFdRRHVJNXpwNzlScldHUWNiTmExSUtpbTBzOTNyR0dJaS9sWjI4Q0VaSyti?=
 =?utf-8?B?RkluTWJoRVBjRDJXYVlZaTF2TlR6cVdFSXFiT2wrMUI4OGNKMTBuVS9hWjRm?=
 =?utf-8?B?dWRLREs5bFVvMDJNUENGVlJnMjhCSWxoeXJUd1dUbjVER2ZpZHUwc2pvQlRR?=
 =?utf-8?B?WmQ4RGdXN2crS1FWeHdERDBvSDdQTFMrTnd0WElvU1dXUGJRSHI1emt4K2dH?=
 =?utf-8?B?SlN5SzFIcnYxVXNkUEJ6RytRbXV5bnMrODNVRlFTREljUS91MFRMaUc0b0p4?=
 =?utf-8?B?cndmV09xeWFCeEU5ZmJGQnpPRVlGYlR4dDNxekpFdXdEc3ZjbUtWTU12SXkz?=
 =?utf-8?B?SHNxT1REWGNFR29xYXEzTTlCOCtmZTQ3OEt4ak5tb0MrcTc2QWVmcFpwWEVJ?=
 =?utf-8?B?OE1Tc2pOSUtjMnF4QVE2bzAvZzdzS29Dd1lJTFhISVl0UE55NlA2cHFQbU96?=
 =?utf-8?B?US9HM2Q4dXY5ZVF5a1FRakM4T3ZscDNyd2dkMmNORVREZXloUHdLVUJpVDFF?=
 =?utf-8?B?VnFYbzE0aXYzdzZLS1BERi9TTnhRUHU3Y1Zab0dUZ1BocFpRbEMyeWR6NnJx?=
 =?utf-8?B?SDZEY3RDV2RVd3kzNzFmYklpcG13L2dZbDVXa2NiTlJtSnJtRUZHZUZPWE9v?=
 =?utf-8?B?TFhuTXY5MDcvL0xDMkovTWZtYlpSL2V1aEVNbHFXZTNGc0I0U29WR1kzcjI2?=
 =?utf-8?B?L2c9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: faca6853-5c65-4eb4-759b-08dabde1630f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 21:21:35.5001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pRheupMFrXLStBMZlsXSQoYEMxPIK1SsFPOfiC/2EKiBA7u2vFTBgLwAfWSRbT9E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1766
X-Proofpoint-GUID: o9Jn6AbfKX8l8CFQljz-JaiMBKMRIy_o
X-Proofpoint-ORIG-GUID: o9Jn6AbfKX8l8CFQljz-JaiMBKMRIy_o
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-03_04,2022-11-03_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/3/22 1:55 PM, Song Liu wrote:
> 
> 
>> On Nov 3, 2022, at 12:45 PM, Yonghong Song <yhs@meta.com> wrote:
>>
>>
>>
>> On 11/1/22 3:02 AM, Jiri Olsa wrote:
>>> On Mon, Oct 31, 2022 at 10:23:39PM -0700, Namhyung Kim wrote:
>>>> The bpf_perf_event_read_sample() helper is to get the specified sample
>>>> data (by using PERF_SAMPLE_* flag in the argument) from BPF to make a
>>>> decision for filtering on samples.  Currently PERF_SAMPLE_IP and
>>>> PERF_SAMPLE_DATA flags are supported only.
>>>>
>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>>>> ---
>>>>   include/uapi/linux/bpf.h       | 23 ++++++++++++++++
>>>>   kernel/trace/bpf_trace.c       | 49 ++++++++++++++++++++++++++++++++++
>>>>   tools/include/uapi/linux/bpf.h | 23 ++++++++++++++++
>>>>   3 files changed, 95 insertions(+)
>>>>
>>>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>>>> index 94659f6b3395..cba501de9373 100644
>>>> --- a/include/uapi/linux/bpf.h
>>>> +++ b/include/uapi/linux/bpf.h
>>>> @@ -5481,6 +5481,28 @@ union bpf_attr {
>>>>    *		0 on success.
>>>>    *
>>>>    *		**-ENOENT** if the bpf_local_storage cannot be found.
>>>> + *
>>>> + * long bpf_perf_event_read_sample(struct bpf_perf_event_data *ctx, void *buf, u32 size, u64 sample_flags)
>>>> + *	Description
>>>> + *		For an eBPF program attached to a perf event, retrieve the
>>>> + *		sample data associated to *ctx*	and store it in the buffer
>>>> + *		pointed by *buf* up to size *size* bytes.
>>>> + *
>>>> + *		The *sample_flags* should contain a single value in the
>>>> + *		**enum perf_event_sample_format**.
>>>> + *	Return
>>>> + *		On success, number of bytes written to *buf*. On error, a
>>>> + *		negative value.
>>>> + *
>>>> + *		The *buf* can be set to **NULL** to return the number of bytes
>>>> + *		required to store the requested sample data.
>>>> + *
>>>> + *		**-EINVAL** if *sample_flags* is not a PERF_SAMPLE_* flag.
>>>> + *
>>>> + *		**-ENOENT** if the associated perf event doesn't have the data.
>>>> + *
>>>> + *		**-ENOSYS** if system doesn't support the sample data to be
>>>> + *		retrieved.
>>>>    */
>>>>   #define ___BPF_FUNC_MAPPER(FN, ctx...)			\
>>>>   	FN(unspec, 0, ##ctx)				\
>>>> @@ -5695,6 +5717,7 @@ union bpf_attr {
>>>>   	FN(user_ringbuf_drain, 209, ##ctx)		\
>>>>   	FN(cgrp_storage_get, 210, ##ctx)		\
>>>>   	FN(cgrp_storage_delete, 211, ##ctx)		\
>>>> +	FN(perf_event_read_sample, 212, ##ctx)		\
>>>>   	/* */
>>>>     /* backwards-compatibility macros for users of __BPF_FUNC_MAPPER that don't
>>>> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
>>>> index ce0228c72a93..befd937afa3c 100644
>>>> --- a/kernel/trace/bpf_trace.c
>>>> +++ b/kernel/trace/bpf_trace.c
>>>> @@ -28,6 +28,7 @@
>>>>     #include <uapi/linux/bpf.h>
>>>>   #include <uapi/linux/btf.h>
>>>> +#include <uapi/linux/perf_event.h>
>>>>     #include <asm/tlb.h>
>>>>   @@ -1743,6 +1744,52 @@ static const struct bpf_func_proto bpf_read_branch_records_proto = {
>>>>   	.arg4_type      = ARG_ANYTHING,
>>>>   };
>>>>   +BPF_CALL_4(bpf_perf_event_read_sample, struct bpf_perf_event_data_kern *, ctx,
>>>> +	   void *, buf, u32, size, u64, flags)
>>>> +{
>>> I wonder we could add perf_btf (like we have tp_btf) program type that
>>> could access ctx->data directly without helpers
>>
>> Martin and I have discussed an idea to introduce a generic helper like
>>     bpf_get_kern_ctx(void *ctx)
>> Given a context, the helper will return a PTR_TO_BTF_ID representing the
>> corresponding kernel ctx. So in the above example, user could call
>>
>>     struct bpf_perf_event_data_kern *kctx = bpf_get_kern_ctx(ctx);
>>     ...
> 
> This is an interesting idea!
> 
>> To implement bpf_get_kern_ctx helper, the verifier can find the type
>> of the context and provide a hidden btf_id as the second parameter of
>> the actual kernel helper function like
>>     bpf_get_kern_ctx(ctx) {
>>        return ctx;
>>     }
>>     /* based on ctx_btf_id, find kctx_btf_id and return it to verifier */
> 
> I think we will need a map of ctx_btf_id => kctx_btf_id. Shall we somehow
> expose this to the user?

Yes, inside the kernel we need ctx_btf_id -> kctx_btf_id mapping.
Good question. We might not want to this mapping as a stable API.
So using kfunc might be more appropriate.

> 
> Thanks,
> Song
> 
> 
>>     The bpf_get_kern_ctx helper can be inlined as well.
> 
>