Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01e8e789-68a8-626e-1a47-814d182807e7@linaro.org>
Date:   Thu, 3 Nov 2022 17:53:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 2/2] dt-bindings: PCI: loongson: Add skip-scan property
 for child node
Content-Language: en-US
To:     Liu Peibao <liupeibao@loongson.cn>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     chenhuacai@loongson.cn, lvjianmin@loongson.cn,
        zhuyinbo@loongson.cn, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221103090040.836-1-liupeibao@loongson.cn>
 <20221103090040.836-2-liupeibao@loongson.cn>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221103090040.836-2-liupeibao@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/11/2022 05:00, Liu Peibao wrote:
> Add the newly added "skip-scan" property for child node.

This we can see from the patch log. You need to say answer here to "Why".

> 
> Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
> ---
>  Documentation/devicetree/bindings/pci/loongson.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml
> index a8324a9bd002..5c2fe9bf2c78 100644
> --- a/Documentation/devicetree/bindings/pci/loongson.yaml
> +++ b/Documentation/devicetree/bindings/pci/loongson.yaml
> @@ -32,6 +32,13 @@ properties:
>      minItems: 1
>      maxItems: 3
>  
> +  child-node:

What is "child-node"?

> +    type: object
> +    properties:
> +      skip-scan:
> +        description: avoid scanning this device.
> +        type: boolean

Why? Isn't status for that?

You also need additionalProperties: false/true, depending on what this
child-node is...

...and add the case illustrating it in the example.


Best regards,
Krzysztof