Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764805AbXHFL6S (ORCPT ); Mon, 6 Aug 2007 07:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763014AbXHFL6J (ORCPT ); Mon, 6 Aug 2007 07:58:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:37687 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbXHFL6H (ORCPT ); Mon, 6 Aug 2007 07:58:07 -0400 Date: Mon, 6 Aug 2007 13:58:04 +0200 From: Olaf Hering To: Stefan Richter Cc: Benjamin Herrenschmidt , Robert Hancock , linuxppc-dev@ozlabs.org, stable@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Message-ID: <20070806115804.GA1734@suse.de> References: <46B4B3DC.7020609@shaw.ca> <46B4B7C6.1040107@s5r6.in-berlin.de> <1186272926.938.8.camel@localhost.localdomain> <46B5824B.1000103@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <46B5824B.1000103@s5r6.in-berlin.de> X-DOS: I got your 640K Real Mode Right Here Buddy! X-Homeland-Security: You are not supposed to read this line! You are a terrorist! User-Agent: Mutt und vi sind doch schneller als Notes (und GroupWise) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 26 On Sun, Aug 05, Stefan Richter wrote: > Benjamin Herrenschmidt wrote: > >>> If setting 32-bit DMA mask fails on ppc64, that sounds like a problem > >>> with the DMA implementation on that architecture. There are enough cards > >>> out there that only support 32-bit DMA that this really needs to work.. > >> Yes, could the PPC folks please have a look at it? Thanks. > > > > Smells like we may have a bug there. No worries though, all current PPC > > machines have an iommu that will not give out addresses above 32 bits > > anyway, but I'll double check what's up. > > > > Do you see something in dmesg when that happens ? > > There was nothing in Olaf's report, except for trouble in sbp2 _after_ > the failure. http://lkml.org/lkml/2007/8/1/344 (I don't have a PMac.) sbp2util_remove_command_orb_pool() does not check for lu->hi being NULL. dev->dma_mask is NULL too, thats why dma_direct_dma_supported() returns false, and dma_set_mask() will return -EIO. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/