Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <35284213-db06-8b6d-8c94-4279f61d6296@ti.com>
Date:   Thu, 3 Nov 2022 17:36:26 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP
 watchdogs as reserved
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>, Julien Panis <jpanis@baylibre.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221103181440.232727-1-jpanis@baylibre.com>
 <20221103181440.232727-3-jpanis@baylibre.com>
 <20221103214754.5feylk5sfem2lvhf@magnetize>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20221103214754.5feylk5sfem2lvhf@magnetize>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/3/22 4:47 PM, Nishanth Menon wrote:
> On 19:14-20221103, Julien Panis wrote:
>> MCU wdt is typically used by M4F.
>> Wake up wdt is typically used by DM (R5) firmware.
>>
>> Signed-off-by: Julien Panis <jpanis@baylibre.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 93a5f0817efc..9ade591ef563 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -503,6 +503,16 @@ &main_mcan0 {
>>   	status = "disabled";
>>   };
>>   
>> +&mcu_rti0 {
>> +	/* MCU RTI0 is used by M4F firmware */
>> +	status = "reserved";
>> +};
>> +
>> +&wkup_rti0 {
>> +	/* WKUP RTI0 is used by DM firmware */
>> +	status = "reserved";
>> +};
>> +
> 
> If this is the typical usage, should'nt we do this in soc.dtsi than
> sprinkle this through various boards?
> 
> Andrew: ?

These are only "reserved" for certain firmware, you choose your RPROCs
and firmware down at the bottom level in board DTs. So I'd say these
statuses should be set at this same level here.

DM firmware might be the exception as it should always be present,
but for M4F firmware, meh, leave it here.

Andrew

>>   &epwm0 {
>>   	status = "disabled";
>>   };
>> -- 
>> 2.37.3
>>
>