Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp30125rwi; Thu, 3 Nov 2022 16:48:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Ed6Vibmk0AR75BygB0Au3gt7mHRRh4oMf8S48+80W87tPZiHYDk5Tn8jc7XNTJvwit4nH X-Received: by 2002:a05:6402:b56:b0:461:91aa:11b7 with SMTP id bx22-20020a0564020b5600b0046191aa11b7mr33610283edb.220.1667519281068; Thu, 03 Nov 2022 16:48:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667519281; cv=none; d=google.com; s=arc-20160816; b=kJhMexEen5gHFsI1raJUY/HcI9DGC0CCCGkAC7JQoHElFZAaLhjUvyT32VGyp0SKhH Ig460S6+YrRG9C3JOvQi0SiU6NDXecUufkvU4DixGpSgpsIEJLQR7WqdwN3LG+32TlyP 0T4vgO4xvBY2VZyZHzaqfBJMbzWX44khjRDGKQ7cYxbL/9OL24Qyi3mgss7WcNPPw4QN ZGa8b9mA+iM4IgCjLJTouBYxJUSSeQ3c38j0k4R4t83yNhmSBsyjxAXhlHsTVFhl2iY2 6FjzQHmLqHiLTMHE0oX86d075U92MBaA51ZJKOI3yP1jkBEeb6x7vK/FJqzR7Ha/nTuS ROqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vFXHtgwdW+sR6NHK/2Q+5sMTWyhXvQL1n6tMJLF2xxY=; b=Wcvnw5s0IJHv9D/NYYxD9DcX6B+w4FNMtNdF8VmR5dgxdKya2PtIwBeba1pzoinzrw vbvoR2/2OXBgKYrJ3KzfsV9BK0HuefVTwmNswhSzg72og3MSE0PyEvpz/PcUnoROtyt1 u0Mvq+eTXz5vjTnaRUlNj5KUaLkVNOvVww7mLiCXQ0Q1M87I7gWocnyI/6eS2OK9MOSH nCGt/t9TLqC+cpkzI1tpMgKxQuM05/aqkhrAbjB+PusFm9btbFvuGG8S7NDF1xx3+t3f qLF2uwcuNQofWLiZAO8E8vJXeL4RluuV2zZ4uQ4f4Z1BWedmiBR6X0114+ECek+ykhBy miKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=BSXGpnI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr13-20020a170907720d00b007aaf5a45f5asi3341814ejc.47.2022.11.03.16.46.55; Thu, 03 Nov 2022 16:48:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=BSXGpnI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiKCXXF (ORCPT + 98 others); Thu, 3 Nov 2022 19:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231379AbiKCXXA (ORCPT ); Thu, 3 Nov 2022 19:23:00 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4C82205C4; Thu, 3 Nov 2022 16:22:44 -0700 (PDT) Received: from zn.tnic (p200300ea9733e72b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e72b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2C7531EC04E2; Fri, 4 Nov 2022 00:22:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667517763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=vFXHtgwdW+sR6NHK/2Q+5sMTWyhXvQL1n6tMJLF2xxY=; b=BSXGpnI0im++wmsWNxkeuxKjQQej60wIR/Sk0cX2RZ7YrtQNhQA0/JrxGI20wDUweZrCEb k+o4bwMt5u5otuBKP/2kTjRja1l1PH+j5LW/iISR7O4Sn/JezDmf47qxabojUHY5r8I2aI FToXcyX9TTPeCYGemSLF53/TOlVnQ5I= Date: Fri, 4 Nov 2022 00:22:39 +0100 From: Borislav Petkov To: Yury Norov Cc: x86@kernel.org, linux-riscv , Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , Dave Hansen , Palmer Dabbelt , Paul Walmsley , Albert Ou , Jonas Bonn , Stefan Kristiansson , Stafford Horne , openrisc@lists.librecores.org, Michael Ellerman , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , linux-s390@vger.kernel.org Subject: Re: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning Message-ID: References: <20221031080604.6xei6c4e3ckhsvmy@kamzik> <20221031100327.r7tswmpszvs5ot5n@kamzik> <20221103125945.lrr5oxxmylwpam53@kamzik> <20221103153404.uh77nrdkowrxj6cr@kamzik> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 10:31:30AM -0700, Yury Norov wrote: > Let's take for example cpu_llc_shared_mask() added by you in > arch/x86/include/asm/smp.h recently: > > static inline struct cpumask *cpu_llc_shared_mask(int cpu) > { > return per_cpu(cpu_llc_shared_map, cpu); > } > > It's in a global header and available to the rest of the kernel, just as > well. Just like static inline struct cpumask *cpu_l2c_shared_mask(int cpu) { return per_cpu(cpu_l2c_shared_map, cpu); } should check != must check. But it's perfectly fine if you're going to attempt to prove some bogus argument of yours - I can safely ignore you. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette