Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764712AbXHFMHD (ORCPT ); Mon, 6 Aug 2007 08:07:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932130AbXHFMGZ (ORCPT ); Mon, 6 Aug 2007 08:06:25 -0400 Received: from mail.suse.de ([195.135.220.2]:59461 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764609AbXHFMGY (ORCPT ); Mon, 6 Aug 2007 08:06:24 -0400 Date: Mon, 06 Aug 2007 14:06:23 +0200 Message-ID: From: Takashi Iwai To: Jesper Juhl Cc: Linux Kernel Mailing List , Manuel Jander , alsa-devel@alsa-project.org Subject: Re: [PATCH] au88x0: mem leak fix in snd_vortex_create() In-Reply-To: <200708040209.25589.jesper.juhl@gmail.com> References: <200708040209.25589.jesper.juhl@gmail.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 24 At Sat, 4 Aug 2007 02:09:25 +0200, Jesper Juhl wrote: > > Hi, > > In sound/pci/au88x0/au88x0.c::snd_vortex_create() : > The Coverity checker found that if we allocate storage for 'chip' > but then leave via the regions_out: label, then we end up leaking > the storage allocated for 'chip'. > I believe simply freeing 'chip' before the "return err;" line is > all we need to fix this, but please double-check me :) > > > Signed-off-by: Jesper Juhl Thanks, applied to ALSA tree now. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/