Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221103090345.187989-1-chenzhongjin@huawei.com>
 <20221103165827.19428-1-kuniyu@amazon.com> <5b05c7d9-a7e3-8b32-4aa6-cd94df2858e5@huawei.com>
In-Reply-To: <5b05c7d9-a7e3-8b32-4aa6-cd94df2858e5@huawei.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 3 Nov 2022 18:57:12 -0700
Message-ID: <CANn89iKW9JFYdZNa5VtHBSLFP0Xe9-1kw+3=Cn0hMe_YqNbfmw@mail.gmail.com>
Subject: Re: [PATCH net] net: ping6: Fix possible leaked pernet namespace in pingv6_init()
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     Kuniyuki Iwashima <kuniyu@amazon.com>, davem@davemloft.net,
        dsahern@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org,
        lorenzo@google.com, netdev@vger.kernel.org, pabeni@redhat.com,
        yoshfuji@linux-ipv6.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 3, 2022 at 6:36 PM Chen Zhongjin <chenzhongjin@huawei.com> wrote:
>
> Hi,
>
> On 2022/11/4 0:58, Kuniyuki Iwashima wrote:
> > From:   Chen Zhongjin <chenzhongjin@huawei.com>
> > Date:   Thu, 3 Nov 2022 17:03:45 +0800
> >> When IPv6 module initializing in pingv6_init(), inet6_register_protosw()
> >> is possible to fail but returns without any error cleanup.
> > The change itself looks sane, but how does it fail ?
> > It seems inet6_register_protosw() never fails for pingv6_protosw.
> > Am I missing something ?
>
> Thanks for reminding! I only injected error return value for functions
> but didn't notice the inner logic.
>
> Rechecked and find you are right that inet6_register_protosw() is safe
> for this case.
>
> Sorry for bothering, please reject this. Will check carefully next time.

This is silly and a waste of time for many of us.

If you want to send fixes for real bugs, I suggest you grab reports
from syzbot queues,
instead of 'injecting error values' from arbitrary functions.

Thanks.