Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Thu, 3 Nov 2022 21:14:41 -0500
From:   Corey Minyard <minyard@acm.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Corey Minyard <cminyard@mvista.com>,
        "Steven Rostedt (Google)" <rostedt@goodmis.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the ipmi tree
Message-ID: <Y2R1kdOS7pHaEtBV@minyard.net>
Reply-To: minyard@acm.org
References: <20221104124840.51ab5b5c@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221104124840.51ab5b5c@canb.auug.org.au>
Precedence: bulk

On Fri, Nov 04, 2022 at 12:48:40PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
> drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
>  1276 |         del_timer_shutdown(&ssif_info->watch_timer);
>       |         ^~~~~~~~~~~~~~~~~~
>       |         device_shutdown
> cc1: all warnings being treated as errors
> drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
> drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
>  5547 |                 del_timer_shutdown(&ipmi_timer);
>       |                 ^~~~~~~~~~~~~~~~~~
>       |                 device_shutdown
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")
> 
> I have used the ipmi tree from next-20221103 for today.

That patch shouldn't have gone it, it's fixed now.

Thanks,

-corey