Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Nov 2022 10:13:59 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
CC:     <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
        <john.stultz@linaro.org>, <sboyd@kernel.org>, <corbet@lwn.net>,
        <Mark.Rutland@arm.com>, <maz@kernel.org>, <kernel-team@meta.com>,
        <neeraju@codeaurora.org>, <ak@linux.intel.com>,
        <zhengjun.xing@intel.com>, John Stultz <jstultz@google.com>,
        Waiman Long <longman@redhat.com>
Subject: Re: [PATCH clocksource 1/2] clocksource: Add comments to classify
 bogus measurements
Message-ID: <Y2R1ZyJhgH5AZLvM@feng-clx>
References: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1>
 <20221102184009.1306751-1-paulmck@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221102184009.1306751-1-paulmck@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?caQIdyrzBP9XwlrnVbAzdEp9Wj7UaCwxW2JYh2+Zez1pGSf7BaOtjA9usVSO?=
 =?us-ascii?Q?dRNNcAe4JsclAN5eFuc+TLVrhDTATnHDumsVx0iNiF8krRbI8k4wypsIQEBv?=
 =?us-ascii?Q?PoatNR4lLbdk2xm7z+roXxUAX9S3dr9gZwx9Ldx8xJuKwcbT6zMwYJhLBb42?=
 =?us-ascii?Q?HFVRj3gebaRX0j8/pynYJh1fVzxRByYzualoTD3Nocv8tZ9xFrNGkpEBBFXd?=
 =?us-ascii?Q?V6DDlwNOWTrxIWw3msgl19kbcJLusqx/DCCq3qxU7E2yoxlUPsGCE/kydD1n?=
 =?us-ascii?Q?pFiSSwzMS96ETgHUgwJgRolrCynd+Nmu5L7hyqwqDiy/1SkQH0irwcz/1WKG?=
 =?us-ascii?Q?RbQH2ZJDLR2EgPMbHPM01iJIWxPejofM0xBIuNjx3STsi0ZaC6Ug5hUrmtED?=
 =?us-ascii?Q?3+VV89ry5GuC1D4lN9db1yUSrgNtgtjFjRWRBdT+TNtr9WlrtOxW52RyAHWD?=
 =?us-ascii?Q?ndwfx399+9Dipbq2+ONifiYh6MrD2je6DM+x5qo3TCRsdpZD2VaBX+PkptcZ?=
 =?us-ascii?Q?TeRwBRc4Pdrsp4SrvBymlcJnF8wBIy9kaOsKQbn0Fe/a3JveES1TKAmxlObx?=
 =?us-ascii?Q?XkZr9+WZjus+Ydg8/rqYue0IdUmUF2fqOG+nixzrUF6rlTJZkQGZ9upYwemm?=
 =?us-ascii?Q?dneSi1EwqMnM/Si6XwMHMnDsw5gV1h2mb8eWfpbz74CfVImVbEiZkBQLcZHQ?=
 =?us-ascii?Q?VwhLww1Ho563kz282auQyaQWGa1gUb9Bgpp9Z5PDnF7ZByD76YFGW3p5GelY?=
 =?us-ascii?Q?W5C0kjXFn8mx63qKujNN0oQSDliGhcvRg1QsU8047PmO5HSJJNXZWnmsindZ?=
 =?us-ascii?Q?+U4z6eNrY25au0PHOuRZWgz8Iqisbj/RmGu/nC+GFdhosPswkPMf/3bS5Fc1?=
 =?us-ascii?Q?CRfwzxIVlPmoDVNxy319mD1F4s/LBcIfhPTwdojqKRXiJsro71EW3sH4bNK5?=
 =?us-ascii?Q?y0hy0h8gF0n82+rFJZ4n9JqOE16YVebeRJPtos7rAE8yNBrS9KrAO/bnz8+n?=
 =?us-ascii?Q?gAH6TISxho5TBlmgaM/cnFUjYU91Dbpts3mkTykO3ai/p6w95oUHdUNCS5Q2?=
 =?us-ascii?Q?Cr7io/2tkTuLVCkxE8jLfwLXKoT/Z9rJYIc5TTCSzwGn9B0oKFbvfTUzL82O?=
 =?us-ascii?Q?QAEU3H4/r+vNi7I0nRBgqDBd/N8Bfd5FzqpkUlfNp2D/Lg7NUMSCT6/9udq1?=
 =?us-ascii?Q?uz/f3Z7fjcVKXwBN0KFxQcWrHecuFtsofnzV+pL9KhhCpBddXS7x7mLzefXu?=
 =?us-ascii?Q?6H/soQ2ImIwzuGOgpZq9ShjpfMJ6kTfxR4qM7fJ0UjTbSZYW78K0A0ytVpbd?=
 =?us-ascii?Q?JmYvI7/oYrO2Ct/j4lkLvX6sWwZY3761HAkzaXnD6gPHNkKw9tgOhTPsuDSm?=
 =?us-ascii?Q?jrQ6/hWnFBqAGonKtoYsF/Ywk5mQPgHZbMRxode8voVjmEAcEaf3m88Lsg1G?=
 =?us-ascii?Q?MIhZX3QuKew02U/u7Q47A3/oUeCbNCgP4Cz8UoU3+eWZc5dzN8M3ylZuldxI?=
 =?us-ascii?Q?o936nYwR4DRyrNDrFgGfFbAygK93zQSezTg+eJu2EqQagWIw9JoVsp4cSCTA?=
 =?us-ascii?Q?rny/2m5tQrIZDrtEw8o59j/jJN83yae4joJAXieL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0898f7f-102d-4a80-6e0d-08dabe0aadf8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 02:17:10.5924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OXxMqKiiiINEBHBGvgZjDxePDuYIAieOqC8dc8nPxv7sWxVn3n5JuV4JOfEyQkKNTBqaQuBE/WN6jjp8ug/9CQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5946
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 02, 2022 at 11:40:08AM -0700, Paul E. McKenney wrote:
> An extremely busy system can delay the clocksource watchdog, so that
> the corresponding too-long bogus-measurement error does not necessarily
> imply an error in the system.  However, a too-short bogus-measurement
> error likely indicates a bug in hardware, firmware or software.
> 
> Therefore, add comments clarifying these bogus-measurement pr_warn()s.

Looks good to me.

Reviewed-by: Feng Tang <feng.tang@intel.com>

> 
> Reported-by: Feng Tang <feng.tang@intel.com>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: John Stultz <jstultz@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Feng Tang <feng.tang@intel.com>
> Cc: Waiman Long <longman@redhat.com>
> ---
>  kernel/time/clocksource.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index dcaf38c062161..3f5317faf891f 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -443,10 +443,12 @@ static void clocksource_watchdog(struct timer_list *unused)
>  		/* Check for bogus measurements. */
>  		wdi = jiffies_to_nsecs(WATCHDOG_INTERVAL);
>  		if (wd_nsec < (wdi >> 2)) {
> +			/* This usually indicates broken timer code or hardware. */
>  			pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL);
>  			continue;
>  		}
>  		if (wd_nsec > (wdi << 2)) {
> +			/* This can happen on busy systems, which can delay the watchdog. */
>  			pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced an excessive %lld ns during %d-jiffy time interval, probable CPU overutilization, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL);
>  			continue;
>  		}
> -- 
> 2.31.1.189.g2e36527f23
>