Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 20:50:32 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     zhang.songyi@zte.com.cn
Cc:     Shannon Nelson <shnelson@amd.com>, snelson@pensando.io,
        drivers@pensando.io, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, brett@pensando.io, mohamed@pensando.io,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        jiang.xuexin@zte.com.cn, xue.zhihong@zte.com.cn
Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable
Message-ID: <20221103205032.4fe32f58@kernel.org>
In-Reply-To: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com>
References: <202211022148203360503@zte.com.cn>
        <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2 Nov 2022 09:07:34 -0700 Shannon Nelson wrote:
> On 11/2/22 6:48 AM, zhang.songyi@zte.com.cn wrote:
> >  From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001
> > From: zhang songyi <zhang.songyi@zte.com.cn>
> > Date: Wed, 2 Nov 2022 20:57:40 +0800
> > Subject: [PATCH linux-next] ionic: remove redundant ret variable
> > 
> > Return value from ionic_set_features() directly instead of taking this in
> > another redundant variable.
> > 
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>  
> 
> Acked-by: Shannon Nelson <snelson@pensando.io>
> 
> ... although these changes usually go through the net or net-next trees.

net-next in this case, but it doesn't apply, please rebase and repost.