Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp164419rwl; Thu, 3 Nov 2022 21:35:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4fiT7eIjhaN1gHvSZReF8vB5O9FAQcat5kzYulzzK9+A9ldBmvAmt2+E/9Qky4bt3YdR4p X-Received: by 2002:a05:6402:1ccd:b0:459:aa70:9e12 with SMTP id ds13-20020a0564021ccd00b00459aa709e12mr33523498edb.206.1667536535503; Thu, 03 Nov 2022 21:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667536535; cv=none; d=google.com; s=arc-20160816; b=L1Fpb/xF4uFAzueoveb+XG86GoZxu1oWdqS6XZ/vPBXu/fKSnAJBqjsO8dPXZLHoCA XjdkLwhiQ75zcjwzrnUzI53LzAQ4JN8fpYzwHYGV5mtrDku0uk3h0LNvC9Nd70o6Cb4i e9J/5IOZFZBXq0mMW/gcegyV098TgvBh1x7JOcnXhUYYaMASDG9ZupV8CthT1qmHq5uE eoYa6GtxgVjWSOEFZPBMrTKMokGppsPUVeS9dsF/w6N4JYYBY24ulEUKJxN9St3phbey A1YBpgPLPc1IJJdcISQo2LfJpfpQ21qykh7dMakWHPmCS1abMCeE47svbGxypXCUaFNE k2rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=w/6LLKhoM97q6w4g+urBSaSriUh2cevBABjP0Zkcrec=; b=ADeEHgtyq7vJvUHlG1hH9BtDO2KOQn5fTZVrj8z5TpkanclVN7eqLjU6DpIR+CQ9hf PuNfjbqGP7aIkKfJsVUPyGu7zdtXexSkSjYkzTilxbDXYNQeCrQfVHmW5cj8QdSO3GU9 +3j83rQHHPI/O2lM6TLORgnZvXzWEF/p7y+kglkpDT1lXbePIQu01s1zgQxeqTmlxySG 3l7S5mVLpNtg+nKyvAXnIt3J/Cx+ZVUlHZQ+lEZsY0hmP4rGkLJNbxtIjF6LiKpm7sJt 42cQxmgaou82q0Y16fqzmU4LNRJ7NiL6UWO6uznHKiQ6/hokyiWd+paKpXxu8LfFJol2 2l4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRUafkPm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o7-20020a17090608c700b0078212b2e6e2si2994265eje.75.2022.11.03.21.34.48; Thu, 03 Nov 2022 21:35:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRUafkPm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbiKDDuq (ORCPT + 95 others); Thu, 3 Nov 2022 23:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKDDui (ORCPT ); Thu, 3 Nov 2022 23:50:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F225D13DE2; Thu, 3 Nov 2022 20:50:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 872A8B82B60; Fri, 4 Nov 2022 03:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B019FC433C1; Fri, 4 Nov 2022 03:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667533834; bh=FyzXENV7WIn5Uu5Adesc2hv84yU5ZUifhCcXpjv7AxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rRUafkPmNamHHAzrr9ZpHYSQa0E9OV1llpGUVJYgC5gMPCmEqmkIznEaAC4rCxtHl d43Curjpua5SgxtS2MEc1dj4orWiAWSucQU8WJ2wM8agLFcHrLm2cBVLP1DBch7vtQ 36l7OJnobeVu7AhEGByHzS3i+tb2hBxzPBz0GiWQdCVZQioqOZfWqLmNOEDcrE83nO rhs3gZslZGNFaOgSBPf/KN/0HGM2Zhw7Qpdaws8AJrLf3X5B+Vgz5EogM1DJBF/QO/ nIHTZAikqPzVVNJFpDRWSKgtCry1WDnCYERwx1HkATQHOUmAMATsRtGY8ZofMddYCO DoAcyqlyzTXMQ== Date: Thu, 3 Nov 2022 20:50:32 -0700 From: Jakub Kicinski To: zhang.songyi@zte.com.cn Cc: Shannon Nelson , snelson@pensando.io, drivers@pensando.io, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, brett@pensando.io, mohamed@pensando.io, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiang.xuexin@zte.com.cn, xue.zhihong@zte.com.cn Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable Message-ID: <20221103205032.4fe32f58@kernel.org> In-Reply-To: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com> References: <202211022148203360503@zte.com.cn> <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Nov 2022 09:07:34 -0700 Shannon Nelson wrote: > On 11/2/22 6:48 AM, zhang.songyi@zte.com.cn wrote: > > From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001 > > From: zhang songyi > > Date: Wed, 2 Nov 2022 20:57:40 +0800 > > Subject: [PATCH linux-next] ionic: remove redundant ret variable > > > > Return value from ionic_set_features() directly instead of taking this in > > another redundant variable. > > > > Reported-by: Zeal Robot > > Signed-off-by: zhang songyi > > Acked-by: Shannon Nelson > > ... although these changes usually go through the net or net-next trees. net-next in this case, but it doesn't apply, please rebase and repost.