Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Nov 2022 11:53:53 +0800
From:   Cai Huoqing <cai.huoqing@linux.dev>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Alexei Starovoitov <ast@kernel.org>,
        SeongJae Park <sj@kernel.org>,
        Peter Chen <peter.chen@kernel.org>,
        Bin Chen <bin.chen@corigine.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from
 decimal to hex to be more readable
Message-ID: <20221104035353.GA10583@chq-T47>
References: <20221101060358.7837-1-cai.huoqing@linux.dev>
 <20221102203640.1bda5d74@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221102203640.1bda5d74@kernel.org>
Precedence: bulk

On 02 11月 22 20:36:40, Jakub Kicinski wrote:
> On Tue,  1 Nov 2022 14:03:38 +0800 Cai Huoqing wrote:
> > The print cmd code is in hex, so using hex cmd code intead of
> > decimal is easy to check the value with print info.
> 
> You're still removing empty lines making this patch much harder 
> to review. Once again - it should be a pure conversion to dec -> hex.
> Don't make any other changes.
Hi, Jakub 

I fix it, and resend v4
https://lore.kernel.org/lkml/20221103080525.26885-1-cai.huoqing@linux.dev/

Thanks,
Cai