Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?UTF-8?q?n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: [PATCH v2 net-next 2/6] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml
Date:   Thu,  3 Nov 2022 21:52:00 -0700
Message-Id: <20221104045204.746124-3-colin.foster@in-advantage.com>
In-Reply-To: <20221104045204.746124-1-colin.foster@in-advantage.com>
References: <20221104045204.746124-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ci5ES4h/nAc7zQUGpw7FJDaDnJEARmBgoMS10yZXvlld5MWYRFg2pCpy42/W?=
 =?us-ascii?Q?l4rKTKM7kv7/v3IyGf0t7WhapYVtXcb7eo1gstsKWDTuJm0WvlWTPHGGbxny?=
 =?us-ascii?Q?Pu+51MzBVnkfdvymXa7BCthJL40k+Ah8DOy0/sQHFy3e8ZzYR8n4IEI+4z98?=
 =?us-ascii?Q?m37LSA/VogEq+6bIsPJWecyfvuO+n1Wmz8FJvTDNLTEm+slUcYYDOYxofdha?=
 =?us-ascii?Q?1mKi0Kke8aX/v1U+u7ly/itaT42kzoGlbvrVUIoY81OaeUaiVNEETy8AFoZC?=
 =?us-ascii?Q?xP5BGuRoHripmo5jdx1FDXb/D7+zR7SlCAzo41COl+LsVeNlBlXdxhb8wNwR?=
 =?us-ascii?Q?kKlSJOzmA12FvJQjxli5hdjZGCfLGZ803Qq3hytGslpaE178lpGGKEK/MU8J?=
 =?us-ascii?Q?vmSmCA63fXaZ3dEbCEFKWobmpO/BKq3MD9oQJ6QpGKDJ5OFmpTqS6EVwI4li?=
 =?us-ascii?Q?/wDlOduNL/37Gi5YmmgI3rizsoWOpF1hCPj3t6SUK/PXURbHG1W2H9fBlQQC?=
 =?us-ascii?Q?Y05pgqBN1/ovTvyxwqpAPJN93Fzs47WQJ/d018TQatCuzs4rfw0c85ka1tDH?=
 =?us-ascii?Q?HUleuoYi+n+ArxQJX+FPu/ZAMXJrvsk2T+B5fTWREU4xHcasaUQv91B0CftP?=
 =?us-ascii?Q?jAqLZWQZeyJeZaIz7Z2we9Eqamixv797VuxavPT3DvTOp+Cg9n++QcWbchL3?=
 =?us-ascii?Q?jYhNp9RQ7f43RalNDsN0Ogvbgal9lpTU6T1udhmT9F396lHd/ZbZfPVRurrM?=
 =?us-ascii?Q?t+uQr4e8KtvTxP/xno7Xkgg98j0aG6omUgzp3mbwIdAYRIxGetQNG/R9F416?=
 =?us-ascii?Q?rhFxLD7H16pvoR+TeaUFhQBA35ckYPsHG8kgOCt8V70+ZRxG5iXStT9aOj6B?=
 =?us-ascii?Q?sO5vXjyMrh8GcL3f3mU0HeVCehqP2Mju2fuHZ0YZmsaP+Y7uo9MwwCuJT5lV?=
 =?us-ascii?Q?9eFAYgIqBTzmjA5GJYqoa/7YhM7yJoY+iCJ1vjge8MjUMdOOXDR720V0mVyr?=
 =?us-ascii?Q?4bTiXTdQLyKYWhqmEv+aEWppR9/Wg2VLXXIgA88datYPz+zl3FW2AOnFTtA9?=
 =?us-ascii?Q?KHinn5DkIm23pd7XaVhHgmTX+wacFYTRWMa5XskZ2iuxYblgdA6jl7q27N8r?=
 =?us-ascii?Q?OvneaMzUXGa4hUVwB/MfdIMTsgR7of+GFoTW/Vw3qv6M/w3nJ4oHGZGAZF+x?=
 =?us-ascii?Q?BRyBmUkfPuNjtvkt0RmYGXtDHjhJpiSdXLFVASxHj7sjbL3fQQJgHKBUa5iB?=
 =?us-ascii?Q?nKWdojRO/YgkklsCl+tmiJ1fqqts6VAoKLVrnqZU0SMznGOa0JHh9mrwh6PZ?=
 =?us-ascii?Q?fMAATtNXAfxsENKrlry0pQiwY4SH7GMN51yTTgfBkElVL17iL/qzPtwyM/f4?=
 =?us-ascii?Q?GvB3emnnXLp1tM31Xea1InJt4FXO06ErnAp3ZnBy+67fRkNRPAutyfB9tcVA?=
 =?us-ascii?Q?/x7vSGP05mHNuzusJn4hzbrYf/e7nrMAHm0vdat1b8x/qUY3A5rdwg/dLWkF?=
 =?us-ascii?Q?cZBuK0Fwln/1x/BJsrJajYj7tUVIdOE/G6JE40Is1Qc6W3yyD9RWjNebtIKT?=
 =?us-ascii?Q?BzpM/1Oj7FmX5UTSQfLd5AQzgO8qxp7en5OnoXbK2wJh6cxNFuJUxjj+iOS2?=
 =?us-ascii?Q?Jnzw13SaQAipmPz1kIFnY7o=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b90a5ae-cb2b-4483-c366-08dabe205a28
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 04:52:19.0635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6+uXihseIS+5FJy/gIe9GEOEVe9UpY8JZ81lqUU0WLkUsD4Y/I/d7ApBWwOr78Thir6F/x8o/Lg+9ZTV+wYx6MlPyOHdgvuIFD0dki7Xb7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5986
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The dsa.yaml binding contains duplicated bindings for address and size
cells, as well as the reference to dsa-port.yaml. Instead of duplicating
this information, remove the reference to dsa-port.yaml and include the
full reference to dsa.yaml.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
Suggested-by: Vladimir Oltean <olteanv@gmail.com>
---

v1 -> v2
  * Add #address-cells and #size-cells to the switch layer. They aren't
    part of dsa.yaml.
  * Add unevaluatedProperties: true to the ethernet-port layer so it can
    correctly read properties from dsa.yaml.

---
 .../devicetree/bindings/net/dsa/qca8k.yaml     | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
index 978162df51f7..d831d5eee437 100644
--- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
@@ -33,6 +33,10 @@ properties:
       qca,qca8334: referenced as QCA8334-AL3C QFN 88 pin package
       qca,qca8337: referenced as QCA8337N-AL3(B/C) DR-QFN 148 pin package
 
+  '#address-cells':
+    const: 1
+  '#size-cells':
+    const: 0
   reg:
     maxItems: 1
 
@@ -66,22 +70,16 @@ properties:
                  With the legacy mapping the reg corresponding to the internal
                  mdio is the switch reg with an offset of -1.
 
+$ref: "dsa.yaml#"
+
 patternProperties:
   "^(ethernet-)?ports$":
     type: object
-    properties:
-      '#address-cells':
-        const: 1
-      '#size-cells':
-        const: 0
-
     patternProperties:
       "^(ethernet-)?port@[0-6]$":
         type: object
         description: Ethernet switch ports
 
-        $ref: dsa-port.yaml#
-
         properties:
           qca,sgmii-rxclk-falling-edge:
             $ref: /schemas/types.yaml#/definitions/flag
@@ -104,7 +102,7 @@ patternProperties:
               SGMII on the QCA8337, it is advised to set this unless a communication
               issue is observed.
 
-        unevaluatedProperties: false
+        unevaluatedProperties: true
 
 oneOf:
   - required:
@@ -116,7 +114,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: true
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.25.1