Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp224077rwl; Thu, 3 Nov 2022 22:40:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4qxvJ5mgYZOtZ8uZ2dnN/XWA2+R2fizSICrm+DFsd34899SAu1hVPUtIZSq1uFqiKeYatA X-Received: by 2002:aa7:c40c:0:b0:458:b42e:46e6 with SMTP id j12-20020aa7c40c000000b00458b42e46e6mr247806edq.375.1667540432809; Thu, 03 Nov 2022 22:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667540432; cv=none; d=google.com; s=arc-20160816; b=m0yfCCwsZ6Z55LPHgxX/U1we3G+J2FdY/a97M5XlzajlCQvEZVLniwALVuxHPhv0se 7ajNxkcLUZC7Dzf8MW5MZwt108ZfpYF/VfMg8h2IPPkPu3AXTmVTEIFgKsoheviNSACj GwvJUN5PmiAkzpAsRvBfBl8qkvuLKdUepLo19nomF36ta5jbgRmCS1EOiyIXGkG2lh0d aBmo3ZB7QRC50khvBQ6uCAZow6aFRzZnOsahKS0gM8f9DgPt+27rcsu6Opp8T87jtRN1 aPgLX8aZaNA/w5xfqE0heT2zgYzWdDWVKYb+ZzacOH4zkS3cINvbU5tpBBNqhMxYNbvC vYAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=zWuG7yleQQUrvodPzd6th53wVqJJUO8chpmr4ThAC4rZCnIIQY9yIpZ5TLtvQZizW3 /mMTBuMf+OkI3Wk5T6A8a5MlbJiKW6t7Gzy3RD8qqtFyVbIBkwmc0eZd8VlvdKXkXriv pENKEpWHe0T9cLJk0K9MGX/OF3xryFStcrah7ohfD2Y0SN9ZSqmsDYZ/THvj+ZQJ0gRO adQELIEiPxdf5CEeWvQjxassORmnBZcq/jhLNSq8r1gDjsRI5NiX7qbx9S7xiZrUZwWd WhZypB3Z+6DRKmgSapfOU10ji2as8NTtqT4pyf5IMkoIkefu3BdeeGs8rtlJjaM2pEoA QHsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga26-20020a1709070c1a00b0078d93245e34si3453240ejc.793.2022.11.03.22.40.09; Thu, 03 Nov 2022 22:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbiKDFRx (ORCPT + 96 others); Fri, 4 Nov 2022 01:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKDFRv (ORCPT ); Fri, 4 Nov 2022 01:17:51 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6068695B7; Thu, 3 Nov 2022 22:17:50 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id BFB5C68AA6; Fri, 4 Nov 2022 06:17:47 +0100 (CET) Date: Fri, 4 Nov 2022 06:17:47 +0100 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2 5/5] blk-iocost: read params inside lock in sysfs apis Message-ID: <20221104051747.GC15721@lst.de> References: <20221104023938.2346986-1-yukuai1@huaweicloud.com> <20221104023938.2346986-6-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104023938.2346986-6-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig