Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   James Calligeros <jcalligeros99@gmail.com>
To:     James Calligeros <jcalligeros99@gmail.com>,
        Viresh Kumar <viresh.kumar@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, nm@ti.com,
        rafael@kernel.org, sboyd@kernel.org, vincent.guittot@linaro.org,
        vireshk@kernel.org
Subject: Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse_supplies()
Date:   Fri, 04 Nov 2022 15:25:43 +1000
Message-ID: <2209158.NgBsaNRSFp@makoto>
In-Reply-To: <20221104050752.67eh54ui2ohbbyni@vireshk-i7>
References: <cover.1667473008.git.viresh.kumar@linaro.org> <2379445.NG923GbCHz@makoto> <20221104050752.67eh54ui2ohbbyni@vireshk-i7>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Friday, 4 November 2022 3:07:52 PM AEST Viresh Kumar wrote:
> It should happen sequentially.

 I noticed the mutexes after I got some sleep :)

> Initialize "ret = 0" in opp_parse_supplies().
> 
> Or pick patches from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next
> 

It didn't even cross my mind that opp_parse_supplies() returning
ret uninitialised was causing the failure further up the chain. Applied
and tested, everything's working as expected now. 

> Sorry for the trouble.

This is on me, I should have heeded the compiler warning.

- James