Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764349AbXHFNir (ORCPT ); Mon, 6 Aug 2007 09:38:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757803AbXHFNii (ORCPT ); Mon, 6 Aug 2007 09:38:38 -0400 Received: from mx1.suse.de ([195.135.220.2]:36586 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757471AbXHFNih (ORCPT ); Mon, 6 Aug 2007 09:38:37 -0400 Date: Mon, 06 Aug 2007 15:38:35 +0200 Message-ID: From: Takashi Iwai To: "Russ Cox" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix selector unit bug affecting some USB speakerphones In-Reply-To: References: <20070621234846.56F401E8C22@holo.morphisms.net> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2038 Lines: 64 At Mon, 6 Aug 2007 09:31:28 -0400, Russ Cox wrote: > > My reading of the maintainers file is that > sound/usb/usbmixer.c belongs to perex@suse.cz > but I got no response to this message, so I am > resending it here. I applied it to ALSA tree. Thanks. Takashi > > Russ > > ---------- Forwarded message ---------- > From: Russ Cox > Date: Jun 21, 2007 7:48 PM > Subject: [PATCH] fix selector unit bug affecting some USB speakerphones > To: perex@suse.cz > > Following the suggestion in this thread: > https://bugs.launchpad.net/ubuntu/+source/alsa-lib/+bug/26683 > the correct upper bound on desc[0] is 5 + num_ins not 6 + num_ins, > because the index used later is 5+i, not 6+i. > > This change makes my Vosky Chatterbox speakerphone work. > Apparently it also helps with the Minivox MV100. > > Signed-off-by: Russ Cox > > --- > sound/usb/usbmixer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c > index 325d4b6..19776e7 100644 > --- a/sound/usb/usbmixer.c > +++ b/sound/usb/usbmixer.c > @@ -1483,7 +1483,7 @@ static int parse_audio_selector_unit(struct > mixer_build *state, int unitid, unsi > struct snd_kcontrol *kctl; > char **namelist; > > - if (! num_ins || desc[0] < 6 + num_ins) { > + if (! num_ins || desc[0] < 5 + num_ins) { > snd_printk(KERN_ERR "invalid SELECTOR UNIT descriptor > %d\n", unitid); > return -EINVAL; > } > -- > 1.4.4.2 > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/