Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 23:17:18 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     bagasdotme@gmail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v2] net: ethernet: Simplify bool conversion
Message-ID: <Y2SubudMxMLV8R8D@hoboy.vegasvil.org>
References: <20221104030313.81670-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221104030313.81670-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Fri, Nov 04, 2022 at 11:03:13AM +0800, Yang Li wrote:

> diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> index c007e33c47e1..37f7359678e5 100644
> --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> @@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
>  static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
>  {
>  	struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
> -	bool neg_adj = scaled_ppm < 0 ? true : false;
> +	bool neg_adj = scaled_ppm < 0;
>  	s64 addend = ptp_priv->default_addend;
>  	s64 diff;

Please preserve reverse Christmas tree order.

Thanks,
Richard