Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 04 Nov 2022 09:06:24 +0100
Message-ID: <871qqjkutb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     aichao <aichao@kylinos.cn>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: fix Hamedal C20 usb camero disconnect issue
In-Reply-To: <20221104073518.120807-1-aichao@kylinos.cn>
References: <20221104073518.120807-1-aichao@kylinos.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 04 Nov 2022 08:35:18 +0100,
aichao wrote:
> 
> For Hamedal C20, the current rate is different from the runtime rate,
> snd_usb_endpoint stop and close endpoint to resetting rate.
> if snd_usb_endpoint close the endpoint, sometimes usb will
>  disconnect the device.
> 
> Signed-off-by: aichao <aichao@kylinos.cn>

OK, this is more understandable than the previous one.

But it doesn't look like a proper workaround, and we need to figure
out the culprit more deeply.  The interface is anyway reset once when
the parameter is changed / re-setup.  Doesn't it hit the same problem?
Or it's about clearing the interface and keep it for long time?

In anyway, please give lsusb -v output of the device.

BTW, is aichao your full name?  The sign-off must be with the real
full name, and it's a legal requirement.


thanks,

Takashi


> ---
>  sound/usb/endpoint.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 533919a28856..c19e420b1780 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -825,7 +825,9 @@ void snd_usb_endpoint_close(struct snd_usb_audio *chip,
>  	usb_audio_dbg(chip, "Closing EP 0x%x (count %d)\n",
>  		      ep->ep_num, ep->opened);
>  
> -	if (!--ep->iface_ref->opened)
> +	if (!--ep->iface_ref->opened
> +		&& (le16_to_cpu(chip->dev->descriptor.idVendor) != 0x0525)
> +		&& (le16_to_cpu(chip->dev->descriptor.idProduct) != 0xa4ad))
>  		endpoint_set_interface(chip, ep, false);
>  
>  	if (!--ep->opened) {
> -- 
> 2.25.1
>