Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] irqchip: loongson-liointc: fix improper error handling in
 liointc_init()
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Jianmin Lv <lvjianmin@loongson.cn>
Cc:     Yinbo Zhu <zhuyinbo@loongson.cn>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221104080347.21527-1-liupeibao@loongson.cn>
 <539b63ee-7655-50c1-a95f-9f8210e7229d@gmail.com>
From:   Liu Peibao <liupeibao@loongson.cn>
Message-ID: <6c14515d-2369-83b5-e20c-0e2a5ba7524c@loongson.cn>
Date:   Fri, 4 Nov 2022 18:59:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <539b63ee-7655-50c1-a95f-9f8210e7229d@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/4/22 5:48 PM, Sergei Shtylyov wrote:
> Hello!
> 
> On 11/4/22 11:03 AM, Liu Peibao wrote:
> 
>> For cores less than 4, eg, loongson2k1000 with 2 cores, the
>> of_property_match_string() may return with an error value,
>> which causes that liointc could not work. At least one isr
>> is what should be checked like previous commit <b2c4c3969fd7>
>> (irqchip/loongson-liointc: irqchip add 2.0 version) did.
> 
>    It should look like this:
> 
> commit b2c4c3969fd7 ("irqchip/loongson-liointc: irqchip add 2.0 version")
> 

Thanks, I will update the patch.

BR,
Peibao

>> Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
>> Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
> [...]
> 
> MBR, Sergey
>