Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp718327rwl; Fri, 4 Nov 2022 05:42:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ANzqt70cIYd+le/ERr5CdhrYJBWjTy8UuC6GYIBKmcB+NOXN7oGbw9JLBErBS9C+LsKMp X-Received: by 2002:a05:6402:1842:b0:461:59b6:3f1b with SMTP id v2-20020a056402184200b0046159b63f1bmr35713205edy.308.1667565770667; Fri, 04 Nov 2022 05:42:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667565770; cv=none; d=google.com; s=arc-20160816; b=QsLpcUbtT1Hlj7w1bHpaWGwx+53FbVAKl0YYkb6h+4B1mmHEBhtAnPU5sc/4k3lQ/e EOlzaz49ZtjT/rjtvGQgcbgYgNgDz+XJLWPCgwMfeRDeSlkDsk/+qA+8yUSNl3bDbBNJ UOyg++lrSd+x1Q5Mgp+EnY0o486hnufjaICcwsdWWUTWuYmtXjkIlT1BFdhbhqgfuDd1 GW5yw8G+8zpQ2zsFB3TGMTs+lQd8mmEDV8Czbf2kFgG1hceBTSq5Xq1wUpQ8IVtvHv75 F791DTzH5C+C0m3nwz5Q4yoDgRV1gm7q6qWxns3unAPt8bMbjV7irWQUZNfI3nfCAxPG kmqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M8WImQ7ZL8KrObKcbD6n0+VmHllyJCHfdjTe3x0R7HQ=; b=aTJN/vORtfqi+sb/bDmhZCQiBEv50nD+dcS2ze+rcRtI9OQFvqitCqK/0cHHhVv7lq bgXngT8jwuMbc2TnviHKLgwCNBMRihnV3ET1WPKs+8z/j0h2FaOm57vu8SHIHErzyk9v GMhB3S+Nwmss1cgn1kjNNOB5Qwpsdz5HdZIFi/nL1+SZsHs0sYWdIjafinyp5yvwwu9t jz7SLkYWtLHQtcRJjmY3Uu6QEEK6sksPo+ccBVkF2IlcoCtsFfGd3b81W1HinQerlf0i ZUjEYWu06ePYvXIzilC4aHuYX9pKWF2BSeyY1HNGJ4kbiw7HIgTKIOCefL1z9IT+aMCM A0Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="dN/GvTKK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a170906344b00b007804b5a2c48si3811261ejb.521.2022.11.04.05.42.27; Fri, 04 Nov 2022 05:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="dN/GvTKK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231791AbiKDKu6 (ORCPT + 96 others); Fri, 4 Nov 2022 06:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbiKDKu4 (ORCPT ); Fri, 4 Nov 2022 06:50:56 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03A692B272; Fri, 4 Nov 2022 03:50:53 -0700 (PDT) Received: from zn.tnic (p200300ea9733e72b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e72b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7F8A81EC02DD; Fri, 4 Nov 2022 11:50:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667559052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8WImQ7ZL8KrObKcbD6n0+VmHllyJCHfdjTe3x0R7HQ=; b=dN/GvTKKqzlUUDakXZilCZ4uSdGe5CAJbJl40VQolvuHhJtQW1xcdTi0YDrLS0QZB0jMhb eQaBUuNsI7Q4vIQY40V9Yc40Te46X3x4T3b1lTvnHpVMUlN4ouXzHpCyZ5uFQO1dFeSUuO ij0Xzs8AtZKYfBUg49QCf7gN02IzTqM= Date: Fri, 4 Nov 2022 11:50:47 +0100 From: Borislav Petkov To: "Joseph, Jithu" Cc: hdegoede@redhat.com, markgross@kernel.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org, ashok.raj@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, thiago.macieira@intel.com, athenas.jimenez.gonzalez@intel.com Subject: Re: [PATCH 07/14] x86/microcode/intel: Expose microcode_sanity_check() Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221021203413.1220137-8-jithu.joseph@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 11:15:12PM -0700, Joseph, Jithu wrote: > If these doesn’t alleviate your concern, I will post v2 without > exporting the aforementioned functions and implementing them > separately in IFS driver as you suggested. So tglx persuaded me yesterday that we should do code sharing after all, so that all blob loading remains consistent. So let's try the cpu/intel.c thing and see what breaks, how and when. As to patch 8, that metadata checking should not be part of microcode_intel_sanity_check() but a separate function. Along with microcode_intel_find_meta_data() - all those should go into the IFS thing. When microcode loading ends up really needing metadata, *then* that functionality should be lifted into a more fitting place like cpu/intel.c Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette