Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i51094778:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8
Mime-Version: 1.0
Message-Id: <9690ec57-4d7e-4a36-8ae3-953de05d3613@app.fastmail.com>
In-Reply-To: <26ce1ec2-effc-435f-8349-a12667973d92@app.fastmail.com>
References: <202211041544.R0jV58vk-lkp@intel.com>
 <26ce1ec2-effc-435f-8349-a12667973d92@app.fastmail.com>
Date:   Fri, 04 Nov 2022 13:09:49 +0100
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Arnd Bergmann" <arnd@arndb.de>,
        "kernel test robot" <lkp@intel.com>
Cc:     clang-built-linux <llvm@lists.linux.dev>,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        "Hector Martin" <marcan@marcan.st>
Subject: Re: drivers/soc/apple/sart.c:190:38: warning: cast from 'void (*)(struct
 device *)' to 'void (*)(void *)' converts to incompatible function type
Content-Type: text/plain
Precedence: bulk

On Fri, Nov 4, 2022, at 09:14, Arnd Bergmann wrote:
> On Fri, Nov 4, 2022, at 09:01, kernel test robot wrote:
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@intel.com>
>
> Thanks for the report!
>
>>>> drivers/soc/apple/sart.c:190:38: warning: cast from 'void (*)(struct device *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
>>
>>            ret = devm_add_action_or_reset(dev, (void (*)(void *))put_device,
>>                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Sven, can you send a patch to add the missing helper function that calls
> put_device?

Sure, I'll send a patch tonight.


Sven