Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f551f177-8163-283d-cf1e-23b09ff35489@linaro.org>
Date:   Fri, 4 Nov 2022 09:21:05 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/4] dt-bindings: iio: frequency: add adf4377 doc
Content-Language: en-US
To:     Antoniu Miclaus <antoniu.miclaus@analog.com>, jic23@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221104092802.90725-1-antoniu.miclaus@analog.com>
 <20221104092802.90725-2-antoniu.miclaus@analog.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221104092802.90725-2-antoniu.miclaus@analog.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/11/2022 05:27, Antoniu Miclaus wrote:
> Add device tree bindings for the ADF4377 driver.

Subject: drop "doc"

> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  .../bindings/iio/frequency/adi,adf4377.yaml   | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> new file mode 100644
> index 000000000000..3f5c83e03bb9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/frequency/adi,adf4377.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADF4377 Microwave Wideband Synthesizer with Integrated VCO
> +
> +maintainers:
> +  - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +  - Dragos Bogdan <dragos.bogdan@analog.com>
> +
> +description: |
> +   The ADF4377 is a high performance, ultralow jitter, dual output integer-N
> +   phased locked loop (PLL) with integrated voltage controlled oscillator (VCO)
> +   ideally suited for data converter and mixed signal front end (MxFE) clock
> +   applications.
> +
> +   https://www.analog.com/en/products/adf4377.html
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adf4377
> +      - adi,adf4378
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 10000000
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    description:
> +      External clock that provides reference input frequency.
> +    items:
> +      - const: ref_in
> +
> +  ce-en-gpios:

chip-enable-gpios

> +    description:
> +      Gpio that controls the Chip Enable Pin.

s/Gpio/GPIO/
(other places as well)

> +    maxItems: 1
> +
> +  enclk1-gpios:

clk1-enable-gpios

> +    description:
> +      Gpio that controls the Enable Clock 1 Output Buffer Pin.
> +    maxItems: 1
> +
> +  enclk2-gpios:

clk2-enable-gpios


> +    description:
> +      Gpio that controls the Enable Clock 2 Output Buffer Pin.
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +

allOf with reference to spi-peripheral-props.yaml

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        frequency@0 {
> +            compatible = "adi,adf4377";
> +            reg = <0>;
> +            spi-max-frequency = <10000000>;
> +            clocks = <&adf4377_ref_in>;
> +            clock-names = "ref_in";
> +        };
> +    };
> +...

Best regards,
Krzysztof