Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     Louis Peens <louis.peens@corigine.com>,
        Baowen Zheng <baowen.zheng@corigine.com>,
        Simon Horman <simon.horman@corigine.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Maksym Glubokiy <maksym.glubokiy@plvision.eu>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: RE: [PATCH net-next] net: flow_offload: add support for ARP frame
 matching
Thread-Topic: [PATCH net-next] net: flow_offload: add support for ARP frame
 matching
Thread-Index: AQHY8Emoobt5Jm60L0KRGicstU9Epa4uthqw
Date:   Fri, 4 Nov 2022 12:50:00 +0000
Message-ID: <MW4PR11MB577629A93F7EB795DF319412FD3B9@MW4PR11MB5776.namprd11.prod.outlook.com>
References: <20221104123314.1349814-1-steen.hegelund@microchip.com>
In-Reply-To: <20221104123314.1349814-1-steen.hegelund@microchip.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?Bss8l5wnL/RRu4sYgLQUBcm2L4IruCyVT9iiR+MBrmJXt7NFFJC5vYZ3Ey?=
 =?iso-8859-2?Q?HOHBTuLcmNywNnf6lLUuKkxIj46X2Ndhap5wKAtjnrjnOYPj5gOpN8FIS5?=
 =?iso-8859-2?Q?Cn6+lnOnb1XC00qw+ACgROhBdYC3/m58fnJT8GQdKIV+M8FezfmcJSekR0?=
 =?iso-8859-2?Q?+Ccv+x5XnHifympN9qcdLO5/2SP8NDA1pzt2NAEUdFQXdUFqacVRs1EnEp?=
 =?iso-8859-2?Q?Ev7ARgc4f65JcDjGNyNGnHJJukW+xRGRd536dmiI7Vx2V29G9P2tEc+RG8?=
 =?iso-8859-2?Q?GdURkSJNMzf7S0+MGU9lUo7G9zkGhKnEminbecN/gkUD6R2Ok0FdTtTPSN?=
 =?iso-8859-2?Q?Te3Si87RL68dKA4oIq002mi+0EEEvLO3mxIObvdZrTi+CTdUUKkyeftaIR?=
 =?iso-8859-2?Q?nIRMGmLR500CnDbXbhjbGyPYykSmIsnMwEzVO/PR8tHBBab0L791Q8WvfY?=
 =?iso-8859-2?Q?vQ0suF58AFRsER9q97HtZGw0MYG57sqGQyryQio9TbMzNYpGYu4DFM6lVm?=
 =?iso-8859-2?Q?Z+b1Pmgf6iXRjkximxuzZOHYFa+mtdfa1ZYUjy75dILQCm9prPvnUhjsGU?=
 =?iso-8859-2?Q?Tut0jZcIUCfFvvfJZorrWWEYUVIDt2Hh5MS7eOxivmtPcMwWV+o6cNf3Ss?=
 =?iso-8859-2?Q?m/mwJXnDByOUEkhiEobrtVmRcYq7ZkWck0ZeOy4aOd9GiL/XW/p6zVGaEp?=
 =?iso-8859-2?Q?S9ZooxyrWGCxbha7Zl+bV7B/cwVudAcJ45itrc9GTQ4O+saXq8h4Oj7mVL?=
 =?iso-8859-2?Q?DnxluKEAaeT0FFeFR6dEb46b3atcDCjPyil9s8Q0CGWY864NT/Dy8RyQz8?=
 =?iso-8859-2?Q?aK0CEeNRzAJE7gDYIVud96JPJg4fMgKtBgn+PSbttOnO4o5gY16L7znM0E?=
 =?iso-8859-2?Q?eS3hO2ASUXFQFzNgOGSTRzRDdRPVkujzgD86XloKBX0fStvdsnlQFcdTaW?=
 =?iso-8859-2?Q?YwZ7Q1aVExSOEsemq9CWNJGB+09yeekPhmA3w+rEDUH36lLgoWERTBT4ke?=
 =?iso-8859-2?Q?gXaR9VmvHFrmdBGG72qpt+DeVBe4ceVmzO1D6v5ybWm9+ONf+CpmQzVyLf?=
 =?iso-8859-2?Q?XjPQT+QkawpNf2O/o+j9ZpinweicC3i2u8Z1v0S8Ksra1yXkE/yRLGD4kM?=
 =?iso-8859-2?Q?oIDGcrhLIG/tleDP7piARFlwARxqU2PGWPFPXkUX3HvoNBRx27rCDgOa3N?=
 =?iso-8859-2?Q?ds8eZGspkQbJmIKqGkIMXDHbHSiglotQn7oIi9Eso55mtkueaXWNEdR3hf?=
 =?iso-8859-2?Q?AqlB76w6hKkgtW0gksMJ9dRwGMebe2Dv2xK3htgnBVSyKCM+NQlJmBAwDd?=
 =?iso-8859-2?Q?AGsAHNsqxY/tYbHjutQKx/HV85e+6hN+PBcX7hJG5uh8+1IX/7QxOJ8r4+?=
 =?iso-8859-2?Q?tZmHSLfgacTd9e1Yloy8HsgUxj/vmiBfUGCxMq+Ikb6JbJIwC8nXyBTe2/?=
 =?iso-8859-2?Q?gFiZUhiOoezzAv0efg8MMkuWl08ppY9dA+SPEI/sBa7WrtEGLj+L7scfUE?=
 =?iso-8859-2?Q?jEklLpM0uQisbof2/9mpgOLmkcZwGj0lGGKHiXhnE8seetgnwWa3ZyZOnf?=
 =?iso-8859-2?Q?Zg5iEs8UXGQkoqWm9LnY483I8kLZfK0AMFz5Rx0nAIhkLzg6bfoGS6KfUR?=
 =?iso-8859-2?Q?Arad0kHr78fTfL1uljQbzASaBIPHVLuuaZ?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 379db1b1-a3f0-47a4-f2be-08dabe6315f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 12:50:00.5317
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nBzkHDKoNpMtPAtZwHM0KGmU2QieuAL2pa2sSrbRPV4nlMm5ZVxR+K4hPmHOgsD9xN6G58NbYQZA4akGy9d6YC8pq2mMlKZUfsKCUEUZlhg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6245
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Steen Hegelund <steen.hegelund@microchip.com>
> Sent: pi=B1tek, 4 listopada 2022 13:33
> To: David S . Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google=
.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Cc: Steen Hegelund <steen.hegelund@microchip.com>; Louis Peens <louis.pee=
ns@corigine.com>; Baowen Zheng
> <baowen.zheng@corigine.com>; Simon Horman <simon.horman@corigine.com>; Ng=
uyen, Anthony L
> <anthony.l.nguyen@intel.com>; Drewek, Wojciech <wojciech.drewek@intel.com=
>; Maksym Glubokiy
> <maksym.glubokiy@plvision.eu>; Pablo Neira Ayuso <pablo@netfilter.org>; n=
etdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> UNGLinuxDriver@microchip.com; Horatiu Vultur <horatiu.vultur@microchip.co=
m>
> Subject: [PATCH net-next] net: flow_offload: add support for ARP frame ma=
tching
>=20
> This adds a new flow_rule_match_arp function that allows drivers
> to be able to dissect APR frames.

ARP* frames
Other than that looks ok.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>=20
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> ---
>  include/net/flow_offload.h | 6 ++++++
>  net/core/flow_offload.c    | 7 +++++++
>  2 files changed, 13 insertions(+)
>=20
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 7a60bc6d72c9..0400a0ac8a29 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -32,6 +32,10 @@ struct flow_match_vlan {
>  	struct flow_dissector_key_vlan *key, *mask;
>  };
>=20
> +struct flow_match_arp {
> +	struct flow_dissector_key_arp *key, *mask;
> +};
> +
>  struct flow_match_ipv4_addrs {
>  	struct flow_dissector_key_ipv4_addrs *key, *mask;
>  };
> @@ -98,6 +102,8 @@ void flow_rule_match_vlan(const struct flow_rule *rule=
,
>  			  struct flow_match_vlan *out);
>  void flow_rule_match_cvlan(const struct flow_rule *rule,
>  			   struct flow_match_vlan *out);
> +void flow_rule_match_arp(const struct flow_rule *rule,
> +			 struct flow_match_arp *out);
>  void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
>  				struct flow_match_ipv4_addrs *out);
>  void flow_rule_match_ipv6_addrs(const struct flow_rule *rule,
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index abe423fd5736..acfc1f88ea79 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -97,6 +97,13 @@ void flow_rule_match_cvlan(const struct flow_rule *rul=
e,
>  }
>  EXPORT_SYMBOL(flow_rule_match_cvlan);
>=20
> +void flow_rule_match_arp(const struct flow_rule *rule,
> +			 struct flow_match_arp *out)
> +{
> +	FLOW_DISSECTOR_MATCH(rule, FLOW_DISSECTOR_KEY_ARP, out);
> +}
> +EXPORT_SYMBOL(flow_rule_match_arp);
> +
>  void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
>  				struct flow_match_ipv4_addrs *out)
>  {
> --
> 2.38.1