Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Nov 2022 06:27:44 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= 
        <naoya.horiguchi@nec.com>
Cc:     James Houghton <jthoughton@google.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yang Shi <shy828301@gmail.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hugetlbfs: don't delete error page from pagecache
Message-ID: <Y2UTUNBHVY5U9si2@monkey>
References: <20221018200125.848471-1-jthoughton@google.com>
 <20221104021035.GA297167@hori.linux.bs1.fc.nec.co.jp>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221104021035.GA297167@hori.linux.bs1.fc.nec.co.jp>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU9rKy8zbERRSkFXUlVZZm5va0NHOEZCc1BsTEZjMHQwOE9PK0JsU0NqT1Vu?=
 =?utf-8?B?ZGdQelhXRU1vNGhuL2R4ZVZmc0ExSWgyV1BVdEc2WjdTbllKN3RybkdpMDN2?=
 =?utf-8?B?QkJFblJzQytCSEVWQVJia2hYbWtqbEpaNFlXU0FNcFRGUzRPS0dCNk9qdUpT?=
 =?utf-8?B?ZUlaa3QzS3lqNzF5NUhGTUVNcFZzWW9adHlhVzdxb3RxZHVLOU9vVEpTZk9h?=
 =?utf-8?B?MXZPNUNraEVVQVpVd0w2aU5hNDdOR1V4THViQmhFN2FqUTZBV3ZEcDRXRGVN?=
 =?utf-8?B?dHpzUVJrTXpNZ1Fqei9vUkRBQndsTWhYZ3ZiYzBwMWdXVld0U3hSNUNKSmVq?=
 =?utf-8?B?OS9SM3ZSSk9Eb2NnQTBmejgzeGVGVFhmMFd6T2hSYm9kWkYyWngwMkNFbTZo?=
 =?utf-8?B?cURkOC85RzVmQ2xKOXYvQ25EK1luNlNNZHRnQWwwdzVPdHQ2Zmtpa2owaXJB?=
 =?utf-8?B?TlhIaE4wYjBJQjB0aDFGS3N4VzF5blp5RXllclQ2eUhDUzY1NndJUHJXZmtm?=
 =?utf-8?B?M1lGdGNLTHVJYVBPME9hT0tjUmpaTTU1Z0p0UkQxSTlQVEZNemNISjlPUXV5?=
 =?utf-8?B?L2pJbkIxelVZdkZCWmNQT3JaY2QxRGtEWnRYL2NYR2R3KzVUVWdTS1NYUVhL?=
 =?utf-8?B?UDZmWlFUQXZXaHFLNUZzUXZnNDQvdHRDUTdyNWNodU1GbFhpanJjNHR0Z3NO?=
 =?utf-8?B?YlBRTnphaTRjdWE3U1hvem43N0RySXJZSXFhWlFmcnRIVXZEWkxrRnhZKytN?=
 =?utf-8?B?VkRkWjVRR01ycS9vVHJFR3VlRm83R3NST0I3Q3hmZGtjTis5WmZSNlJBaUNa?=
 =?utf-8?B?VXFpdnI4MGFwZzhRdmJPK0k3d3ZhbUpiZFpjM0hjSXZHemtjZ1BHMHJJS01k?=
 =?utf-8?B?WlFrTDJuU1BCcGZhT2hvSzJ0ZWlZUVhGSSt1VkRNNlEzQXQybmZnM0cxSFlV?=
 =?utf-8?B?TUNla1Z1d1NXVDVubldxVWVZYjdiRC9TdTQ0V3V3R2FrQ1JJWXNJZ1JhTW5E?=
 =?utf-8?B?NmpLa0w5R3JndTlLbTQwSzdMV0R0RGhGWnhoakFZenQrdmFzMzYySlNsVzh1?=
 =?utf-8?B?VWVodlJ4SHQyVWdjcFlSdVJ5ZzJUYmdGMzNwMm92a2lpSnR2YzNaUXIrSkRy?=
 =?utf-8?B?WUc0SFNZdzQ1MjQzblc0cmFUNnF4b3JhQUlLTFdJQ0xjYXlyT0VKSDdXRDBX?=
 =?utf-8?B?MGJwWXRTMVdEUnR1b01kWnBBUVFyWlFrSnhLaS9xQjZnWGZsS0lubnBOSkFr?=
 =?utf-8?B?eGpqSmViSWFjY3ptOHoxbk9UaVFHWG5hWWphU2ZPdU5ZWSszWUJ6Tjhac0tq?=
 =?utf-8?B?THZPZjRwUVo0SG05WWdnNkkwSVlYcE9GT3lDYkpzbk5WeEErdGlndEI1YzJx?=
 =?utf-8?B?WWVrbWtUODZVVXlNQ0o1NFJvM0x0cXNDMTFHaGtiRWJ2Q1VXdWhoa3ZoaytL?=
 =?utf-8?B?eDQwRzR5NklrYXpkclU1eWdRcDJGZ3BLZ1hOMDZFVEVTVHZVMkhCYzFOdTZJ?=
 =?utf-8?B?d1IreU5JVXdDNW5lcnozaDlaVGVTT1N3cEgwZUhhYTNCbEpaWk1vanVCcTZ5?=
 =?utf-8?B?ZDVhdUpWeWowSitvNjk0ZWhkc2c0RnlhVTNhS2I5YWNyV3RjRStPSmZ1anNC?=
 =?utf-8?B?MnBCNlEwc0hLWUdMVitHZ0tzMlYxNFVQNFFvUnFlVXhMRERSVXdadnBlMWE3?=
 =?utf-8?B?M1hMUGlUaXlPdGFiZXhxZU5hNno4UW9CaDlFS0VXb25pSE1FaTBsNEtiNk1a?=
 =?utf-8?B?TWRNbGkyOVloWUZxR093Q1N5Wmh2Mjc2Q0dPS0cyZlNobGpYclh1bnd1YkVK?=
 =?utf-8?B?OTZlU0FWbWhZLytKWjBydzh1ajZReFFyWVdQUzQ5aFdTKzVnbGdxV3htY25V?=
 =?utf-8?B?aHdkbllSajZQK1JYRWk1d21xamJ5TGdzUngxaGlCTHFiRXFrV0lDb1pRcHQx?=
 =?utf-8?B?MlNNYmZjMEE3MUpxdGp1dk1EWHVJS204TjVWa2czV2tpa0dwN2h6QjNXRmYw?=
 =?utf-8?B?UEkxdXJTUWRvK1RBUVpvbHN2NWRGL29PR2hOQ1owcHpFNTVQY213cm1Qd0xF?=
 =?utf-8?B?dHNTQUtRekJCTUt1cVFPa1JrZkdGWG11aVJ6bUlZYTVoN0tFci9sZERLUWEy?=
 =?utf-8?B?OUU4b0lkdjUveDdnRzFvSTQxUUZmUGhCREsyTFRxbU5lWWt4TDM1eUZuNVZK?=
 =?utf-8?B?b3c9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5fb7907-3abe-4529-5df9-08dabe6863fd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 13:27:59.3207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wpqx6OXWCrjzDVdejdI3YVPDIXKYZTBZxYnNXzDtL/A93hCnxCTszaXKRttn628tLq5V4o8Q+llU/pwM039Msg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6315
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-04_09,2022-11-03_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211040089
X-Proofpoint-GUID: hIjfeXvC6Ou7t2k9B_ktyqXc1hTkgrPw
X-Proofpoint-ORIG-GUID: hIjfeXvC6Ou7t2k9B_ktyqXc1hTkgrPw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/04/22 02:10, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Tue, Oct 18, 2022 at 08:01:25PM +0000, James Houghton wrote:
> > This change is very similar to the change that was made for shmem [1],
> > and it solves the same problem but for HugeTLBFS instead.
> > 
> > Currently, when poison is found in a HugeTLB page, the page is removed
> > from the page cache. That means that attempting to map or read that
> > hugepage in the future will result in a new hugepage being allocated
> > instead of notifying the user that the page was poisoned. As [1] states,
> > this is effectively memory corruption.
> > 
> > The fix is to leave the page in the page cache. If the user attempts to
> > use a poisoned HugeTLB page with a syscall, the syscall will fail with
> > EIO, the same error code that shmem uses. For attempts to map the page,
> > the thread will get a BUS_MCEERR_AR SIGBUS.
> > 
> > [1]: commit a76054266661 ("mm: shmem: don't truncate page if memory failure happens")
> > 
> > Signed-off-by: James Houghton <jthoughton@google.com>
> 
> I did some testing and found no issue. So I agree with this patch.
> Thank you very much.
> 
> Tested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> 
> As for whether to go with HGM patchset or not, I have no strong opinion.
> As you stated in another email this patch is correct without HGM patch,
> so it's OK to me to make this merged first.

Thanks Naoya.

This is a late thought, but ...
Should this patch and Yang Shi's shmem patch be backported to stable releases?
Both address potential data corruption/loss, so it certainly seems like
stable material.
-- 
Mike Kravetz