Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6af9d462-885a-df77-2c83-588363026e7f@baylibre.com>
Date:   Fri, 4 Nov 2022 15:04:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC
Content-Language: en-US
To:     Lee Jones <lee@kernel.org>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com,
        will@kernel.org, tony@atomide.com, vigneshr@ti.com,
        bjorn.andersson@linaro.org, shawnguo@kernel.org,
        geert+renesas@glider.be, dmitry.baryshkov@linaro.org,
        marcel.ziswiler@toradex.com, vkoul@kernel.org,
        biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com,
        afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com,
        msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-input@vger.kernel.org, linux-omap@vger.kernel.org
References: <20221011140549.16761-1-jneanne@baylibre.com>
 <20221011140549.16761-5-jneanne@baylibre.com> <Y1+q2Usm9ecicXqp@google.com>
 <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com>
 <Y2UaCq+EL0f2mJ3p@google.com>
From:   jerome Neanne <jneanne@baylibre.com>
In-Reply-To: <Y2UaCq+EL0f2mJ3p@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 04/11/2022 14:56, Lee Jones wrote:
> On Fri, 04 Nov 2022, jerome Neanne wrote:
> 
>>
>>
>> On 31/10/2022 12:00, Lee Jones wrote:
>>>> diff --git a/include/linux/mfd/tps65219.h b/include/linux/mfd/tps65219.h
>>>> new file mode 100644
>>>> index 000000000000..2c1cf92e92ac
>>>> --- /dev/null
>>>> +++ b/include/linux/mfd/tps65219.h
>>
>>>> +/**
>>>> + * struct tps65219 - tps65219 sub-driver chip access routines
>>>> + *
>>>> + * Device data may be used to access the TPS65219 chip
>>>> + *
>>>> + * @dev MFD device
>>>> + * @regmap Regmap for accessing the device registers
>>>> + * @irq_data Regmap irq data used for the irq chip
>>>> + * @nb notifier block for the restart handler
>>>> + */
>>>
>>> This header needs work.
>> I'm not sure to get your point here. Just something like below to match
>> format or do you expect more:
>>
>> /**
>>   * struct tps65219 - tps65219 sub-driver chip access routines
>>   *
>>   * Device data may be used to access the TPS65219 chip
>>   *
>>   * @dev: MFD device
>>   * @regmap: Regmap for accessing the device registers
>>   * @irq_data: Regmap irq data used for the irq chip
>>   * @nb: notifier block for the restart handler
>>   */
>>
>>>
>>> Can you try an compile with W=1 please.
>> This raise one warning on mfd:
> 
> Is that before or after the header was fixed-up?
After the header was fixed-up.
> 
>> drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but
>> not used [-Wunused-function]
>>     28 | static int tps65219_soft_shutdown(struct tps65219 *tps)
>>        |            ^~~~~~~~~~~~~~~~~~~~~~
>> soft_shutdown has been validated and is used in TI baseline even if not
>> hooked in upstream version further to this review:
>> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/
> 
> Will tps65219_soft_shutdown() be used?
> 
> I think it should be removed until it's utilised in Mainline.
> 
I'll remove then

Thanks for your feedback