Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221103210421.359837-1-pgonda@google.com> <Y2Q/3A1DSzSJkRAy@google.com>
In-Reply-To: <Y2Q/3A1DSzSJkRAy@google.com>
From:   Peter Gonda <pgonda@google.com>
Date:   Fri, 4 Nov 2022 08:23:29 -0600
Message-ID: <CAMkAt6qHVfpKoi2YYDp4L9CQefU_MAJTdM2P4LoubiS+-64OXQ@mail.gmail.com>
Subject: Re: [PATCH] KVM: SVM: Only dump VSMA to klog for debugging
To:     Sean Christopherson <seanjc@google.com>
Cc:     jarkko@kernel.org, Harald Hoyer <harald@profian.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 3, 2022 at 4:25 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Thu, Nov 03, 2022, Peter Gonda wrote:
> > The KERN_CONT documentation says it defaults back to KERNL_DEFAULT if the
>
> State what actually happens.  Documentation is sometimes wrong, and just saying
> "the docs say XYZ" makes it sound like this is a fix based on code inspection,
> whereas you encountered a real problem.  E.g.
>
>   Explicitly print the VMSA dump at KERN_DEBUG log level, KERN_CONT uses
>   KERNEL_DEFAULT if the previous log line has a newline, i.e. if there's
>   nothing to continuing, and as a result the VMSA gets dumped when it
>   shouldn't.
>
> > previous log line has a newline. So switch from KERN_CONT to
> > print_hex_dump_debug().
>
> Jarkko pointed this out in the original submission, but the buggy patch got queued
> without the fixup.  This is a good opportunity to throw in a link so that it's
> clear that the change is aligned with the original intent.
>
>   Link: https://lore.kernel.org/all/YuPMeWX4uuR1Tz3M@kernel.org

Thanks. I've expanded on the description based on your feedback.

>
> > Cc: Jarkko Sakkinen <jarkko@kernel.org>
> > Cc: Harald Hoyer <harald@profian.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Sean Christopherson <seanjc@google.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: x86@kernel.org
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: kvm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Peter Gonda <pgonda@google.com>
> >
> > Fixes: 6fac42f127b8 ("KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog")
>
> Fixes: usually goes before everything else, and this should probably Cc stable@
> as well.
>
> With the above tweaks,
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>

Done. Sent a V2 with your review tag.