Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Maxime Chevallier <maxime.chevallier@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Robert Marko <robert.marko@sartura.hr>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description
 for the IPQESS Ethernet controller
Thread-Topic: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description
 for the IPQESS Ethernet controller
Thread-Index: AQHY8FmpmsPL59Zv3k23UVCewDzxaK4u03IAgAAAfAA=
Date:   Fri, 4 Nov 2022 14:32:50 +0000
Message-ID: <20221104143250.6qjkphkhrycp75rv@skbuf>
References: <20221104142746.350468-1-maxime.chevallier@bootlin.com>
 <20221104142746.350468-6-maxime.chevallier@bootlin.com>
 <50814a5b-03d3-95b4-ab14-bfd19adae52b@linaro.org>
In-Reply-To: <50814a5b-03d3-95b4-ab14-bfd19adae52b@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m/09n30seC+iw2UkP32Wn4Ilubcfp3OH96k5dfyZEPKhj8rSHBQPdp3SGtx8?=
 =?us-ascii?Q?j0E826TbGdcvp3G8nRJUs8aMyHRY6GULIjQPGs09mhyD86pSl19tNMMf13or?=
 =?us-ascii?Q?c0QfFJLdrxx89DaJlGmzogjBuQZkRnaUBCTW551FgnQpY54tEIMXyDQ4pTFj?=
 =?us-ascii?Q?mi6aCwqkxoJ6YopE4zEzFdwNCQa95iHJhes5DeNqcVMToW0aD1PJdbIz8bvK?=
 =?us-ascii?Q?3LUuvFAWxbhkw/iFgzEyjXfATbIqhG3vYW8dgKIfgyafV+kkAucpAFzcleHH?=
 =?us-ascii?Q?6qi1I7RJC3mHT9PbMFh/T4gP9PXPyymjZk8uFh/mvkFLaLPgBSySNdSdBdjz?=
 =?us-ascii?Q?2RrNdNr/fNsvo+FeW3Hp/CIk5/TOqD84r1esolKVj729ya6v98zUDm1MWvQq?=
 =?us-ascii?Q?3Fm/eI6pBQa/+TE61N/LuAIksqBMr+5xUSRuccZKhUT88edH7SQjyn7frQQ1?=
 =?us-ascii?Q?Foj6T9g1SWFSKJXYKtzdPtNYZ8krBWNeCTbM2M+4KdAIEKhqGQwQe3d+4VhK?=
 =?us-ascii?Q?PX4xhWyoquHTma9U7QqdOdT+uDFm2X38ZBT8N7WbPcH2mucwi3c70iRkk8FL?=
 =?us-ascii?Q?U9Isklz3g357e12l2Wp6OVKEnN9oUT/OxEv+zGpGJH0C+lp3xs1/1zea4SqK?=
 =?us-ascii?Q?BgA5iYpSNW4k94teCYvw1G1sFzD3dNZPZJHp/ATwqiWdLuXqkSSwApcvq/7O?=
 =?us-ascii?Q?zzDuuFNNTRz7fWsmzUzx3XM2HeadBTI5XGQh2sIs44WFHevbin97UCciV/E/?=
 =?us-ascii?Q?ghfWx1eF4n5alWKZaoMADClAbercQf4RkoEfNOZ/fBjtDWY1yrU0/DIdpumc?=
 =?us-ascii?Q?gzIGEJbOLdY5Ud0TBaMn68S4PariyXqmUrv5BcHyLrkRqnsWIpcrSpTvsIaF?=
 =?us-ascii?Q?SNKXoKbc36fZlY7C3X4E3PtfxJvPpyswsNsLHiNreVO3YD2FKXLfdlB9gaoC?=
 =?us-ascii?Q?jGg2TGYKnj9imcy9zCvw6TeMnahkZANDW7REJbh9tLHWGqMp0+dHC4wR3Ny2?=
 =?us-ascii?Q?cduYAT1mY7x+u/M9kyCmgbG213+i2GuS2S6++qT3zRDJ4j913R/2LvpOWD5z?=
 =?us-ascii?Q?s4orf9uHV7rD/AaM5bu8U5EOkFRBehm3wStPFY/F6Qv+nRttK/3XfdKA/5Ya?=
 =?us-ascii?Q?DY4t+1tYXEZTGUSMDL9oUl/uOQac1yAufVGzPqYOTJe/DljJdxfa73m4nBoh?=
 =?us-ascii?Q?yugIMLpeD58sKIhuCqxYB+bOTIMwDeq08X+QefohW9+CLC8HSnqiIEw+1nAl?=
 =?us-ascii?Q?BC9NmirpRWJPnHkFBylEficps3eUgf3jasND7TpcdP8X/Ju1yMR3UItMX7rr?=
 =?us-ascii?Q?epEdSoP8ZQQUu1VmL+tefqLeJtwr8YYbbiVU8qthf+BgtHfcf1SYuiRaobuV?=
 =?us-ascii?Q?4wnbPvhmq4jcZvESkkigGg1J1wGY3Nnw3s3gJuwasoUamZoDVKPVxV4BW1EG?=
 =?us-ascii?Q?fZXRHVtj1fuKRroATvZ5UWCUaLl70J4egoNVJ4IHOfTPvYRFw6XanXsT1ycy?=
 =?us-ascii?Q?T+qTkx2sNjGDs068dEWyULIdTkqfvWjRhHEqLFV1CkQPHpw+meyl5NGwjeac?=
 =?us-ascii?Q?JsnIs9XUr+lWZpE3DXCHOh3vk6CYRIfwpnUIk3dagpzHZxc+JXsHNNm1EtCe?=
 =?us-ascii?Q?lA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <007924274551D24F8388772AFD35525D@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cee70430-3246-4a81-701d-08dabe7173c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 14:32:50.8819
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pSJicNI5ILchXQT/U0ggEwtHLXpuLLtfgX8K79yFBlMe73gayq/5Le9BodBjt5wXmvPx1+Vm3r+YYYg6WrB3TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9181
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 04, 2022 at 10:31:06AM -0400, Krzysztof Kozlowski wrote:
> > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qc=
om-ipq4019.dtsi
> > index b23591110bd2..5fa1af147df9 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > @@ -38,6 +38,7 @@ aliases {
> >  		spi1 =3D &blsp1_spi2;
> >  		i2c0 =3D &blsp1_i2c3;
> >  		i2c1 =3D &blsp1_i2c4;
> > +		ethernet0 =3D &gmac;
>=20
> Hm, I have doubts about this one. Why alias is needed and why it is a
> property of a SoC? Not every board has Ethernet enabled, so this looks
> like board property.
>=20
> I also wonder why do you need it at all?

In general, Ethernet aliases are needed so that the bootloader can fix
up the MAC address of each port's OF node with values it gets from the
U-Boot environment or an AT24 EEPROM or something like that.=