Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org>
Date:   Fri, 4 Nov 2022 15:41:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] rtla: Fix exit status when returning from calls to
 usage()
To:     John Kacur <jkacur@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-trace-devel@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>,
        Clark Williams <williams@redhat.com>,
        Chang Yin <cyin@redhat.com>
References: <20221103135742.9523-1-jkacur@redhat.com>
Content-Language: en-US
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20221103135742.9523-1-jkacur@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/3/22 14:57, John Kacur wrote:
> rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> error status

missing .

> However when these are called from help, they should exit with a
> non-error status.
> 
> Fix this by passing the exit status to the functions

missing .

> Note, although we remove the subsequent call to exit after calling
> usage, we leave it in at the end of a function to supress the compiler

suppress?

> warning "control reaches end of a non-void function"

missing .

Yep, that is a problem, and agree with the solution (I am already doing it
in the rv cmd line).

-- Daniel