Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f5218ef-7c68-dc2c-27f8-eeb01ba3813a@somainline.org>
Date:   Fri, 4 Nov 2022 15:36:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH v10 3/4] arm64: dts: qcom: sc7280: Add touchscreen and
 touchpad support for evoker
To:     Doug Anderson <dianders@chromium.org>
Cc:     Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
References: <20221104061941.2739938-1-sheng-liang.pan@quanta.corp-partner.google.com>
 <20221104141515.v10.3.I3ac715e729f6f9b5a3e3001b155df4f9d14e6186@changeid>
 <139c06eb-14b8-10b5-80b7-ba8ec8579846@somainline.org>
 <CAD=FV=VwP_s5y0MVNLs+WGD_=nJtJe7h=n+Xu4Ky5RvgdkAw9Q@mail.gmail.com>
 <b6e8da04-f5bf-8e27-e4b7-3854d4168a08@somainline.org>
 <CAD=FV=Xsd6Do_RGN-F_Ef0uxBOqERNGUjme9nCE6Xu49kTOzcw@mail.gmail.com>
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <CAD=FV=Xsd6Do_RGN-F_Ef0uxBOqERNGUjme9nCE6Xu49kTOzcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/11/2022 15:32, Doug Anderson wrote:
> Hi,
> 
> On Fri, Nov 4, 2022 at 7:28 AM Konrad Dybcio
> <konrad.dybcio@somainline.org> wrote:
>>
>>
>> On 04/11/2022 15:25, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Nov 4, 2022 at 2:35 AM Konrad Dybcio
>>> <konrad.dybcio@somainline.org> wrote:
>>>>
>>>> On 04/11/2022 07:19, Sheng-Liang Pan wrote:
>>>>> Change touchpad and touchscreen node for evoker
>>>>> Touchpad: SA461D-1011
>>>>> Touchscreen: GT7986U
>>>> What's the reasoning? Were they changed post r0? Is r0 support
>>>> effectively dropped?
>>>>
>>>> The changes look ok, but I feel like this needs more of a comment in the
>>>> commit msg.
>>> As I understand it r0's toucscreen/touchpad were not right to start
>>> with. We are moving towards getting things upstream sooner and that
>>> means that hardware hasn't always been fully tested out.
>>>
>>> I certainly wouldn't object to a better commit message here, but in
>>> this case there are no real world users (yet) and thus nobody is
>>> really affected by this churn. ...so IMO if the series needs to be
>>> spun for some other reason then the commit message could be updated,
>>> but I wouldn't object to it landing as-is either.
>>
>> If there are no real (read: not-an-internal-devboard) devices using it,
>> then I
>>
>> agree, it's fine to merge as-is.
> 
> I can confirm that. There are no evoker devices in the wild.
> 
> -Doug
In this case:

Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Please include explanations like these in the commit message next time.

Konrad