Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1009914rwl; Fri, 4 Nov 2022 08:47:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6tXuOFIKu6FCdABawHA0ZD31XoLzTwR8jUibpVLYZnlVD53UvH2EVmFlngnulIM2O9eLM+ X-Received: by 2002:a05:6a00:114c:b0:528:2c7a:6302 with SMTP id b12-20020a056a00114c00b005282c7a6302mr36575223pfm.37.1667576863937; Fri, 04 Nov 2022 08:47:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667576863; cv=none; d=google.com; s=arc-20160816; b=IlT4jrxPCFMgdSRaoRdmu+uk02rZeXm6yLJPFsvByBVf4SZtrcMgiJafa7a6tPa5RG zgvYFZMG7fslOwpeA89f1ARZJcQKtWAjDLh12kPsgJ+VF3Ka1KCNI5YGbLaDO3cSA9BR 1Muwlc/ZHhURpUtkMHvSHeSdWydvI+NIHH8V2JJvtTnpBEyw0Og0wCZwEW4FcmkiZiSd SGobWyv2jKzIjHtN2amALDwlWDOPNepvZNUeYzAzOOn7FCKYeNAujDdKPpN2uT+60WIu QAy+mHTOmVMd/yK28CDqUWTa5FxfkFzMFdNCGejGZk1CfVUPrLcWUHyCIXOrwCwpSkaX fxZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZKFnSxLXDatKBkXItM/QEvdVVLbEAS41YYxcIOyoxRE=; b=LP55BpaIoJ6rYlvwIxRXe1APuZVjylSl0dzMXiOtch1Qjx2d3GnUlphVp3Fu6JFk/l QNhaqc69v/9HJIqIhygvHGm5FB1mAW+HET3H++QglwsqZaMLbstW40ivdP7q5uUY2bJ9 LIWdgwTQb2tkzv8sBEHzP8Gf53vDB3T57QhKf02skVbg+lDEUIvKAm/29sywwasIAOi9 NNKKQjPDbU5qOmrBD3AH0RhgZFMlQeIymiANmeq+g5FHZZ9TToq1chjh1Woa1FkpiAsm Z7S1VySAWyvFe2mIg7QnHm74GXL9xoHZ2ZWwYwe6l8NLqWmlfCP0m9AthJyQt/2CLKir nXlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SML8AXMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f4-20020a170902ce8400b001755f43df36si5520080plg.479.2022.11.04.08.47.30; Fri, 04 Nov 2022 08:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SML8AXMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbiKDOoS (ORCPT + 96 others); Fri, 4 Nov 2022 10:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbiKDOoA (ORCPT ); Fri, 4 Nov 2022 10:44:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C63831DE1; Fri, 4 Nov 2022 07:43:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27EA562207; Fri, 4 Nov 2022 14:43:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18450C433C1; Fri, 4 Nov 2022 14:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667573024; bh=UBbkqkVceLOOAXfkK0cOsW2bKaYhwR/pDIEt/9iU3Sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SML8AXMir9D9NFZrj5BLUfryJLJoZlXJLzxsPjgDTtfXha9tKT+ZNezKaXvoWRB30 8b6BJBtm1hyNNU90UxQ4Wpz/Der716VtsAAuPjeM8FD5vepwjpPH6QV9LuA+RGqSrI UHxphMk9rFS9C6O8Sddr8XPbcUF6lZmOKNcoa3sfdmfK/ZsyDT6mWRRpGH8Pazhrh2 cImPlnuijV+Ac9AtSCPShqkoadseh37DBVi+b+syszZ9HWsa2s1LnlDYgkMkkhKGKu yBgOQGlwM6jV9E1Jh/cSFEa/cOEILR2eSiptQQfod224Y4sDWbR5jyXu1pPt6dUDW8 PBT+AcjxpUyNw== Date: Fri, 4 Nov 2022 20:13:40 +0530 From: Vinod Koul To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: stm32-dma: fix potential race between pause and resume Message-ID: References: <20221024083611.132588-1-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024083611.132588-1-amelie.delaunay@foss.st.com> X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-10-22, 10:36, Amelie Delaunay wrote: > When disabling dma channel, a TCF flag is set and as TCIE is enabled, an > interrupt is raised. > On a busy system, the interrupt may have latency and the user can ask for > dmaengine_resume while stm32-dma driver has not yet managed the complete > pause (backup of registers to restore state in resume). > To avoid such a case, instead of waiting the interrupt to backup the > registers, do it just after disabling the channel and discard Transfer > Complete interrupt in case the channel is paused. Applied, thanks -- ~Vinod