Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3bdb7b04-27a2-8d50-b96a-76ad914a0988@linaro.org>
Date:   Fri, 4 Nov 2022 11:08:07 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description
 for the IPQESS Ethernet controller
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     Maxime Chevallier <maxime.chevallier@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Robert Marko <robert.marko@sartura.hr>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
References: <20221104142746.350468-1-maxime.chevallier@bootlin.com>
 <20221104142746.350468-6-maxime.chevallier@bootlin.com>
 <50814a5b-03d3-95b4-ab14-bfd19adae52b@linaro.org>
 <20221104143250.6qjkphkhrycp75rv@skbuf>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221104143250.6qjkphkhrycp75rv@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/11/2022 10:32, Vladimir Oltean wrote:
> On Fri, Nov 04, 2022 at 10:31:06AM -0400, Krzysztof Kozlowski wrote:
>>> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
>>> index b23591110bd2..5fa1af147df9 100644
>>> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
>>> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
>>> @@ -38,6 +38,7 @@ aliases {
>>>  		spi1 = &blsp1_spi2;
>>>  		i2c0 = &blsp1_i2c3;
>>>  		i2c1 = &blsp1_i2c4;
>>> +		ethernet0 = &gmac;
>>
>> Hm, I have doubts about this one. Why alias is needed and why it is a
>> property of a SoC? Not every board has Ethernet enabled, so this looks
>> like board property.
>>
>> I also wonder why do you need it at all?
> 
> In general, Ethernet aliases are needed so that the bootloader can fix
> up the MAC address of each port's OF node with values it gets from the
> U-Boot environment or an AT24 EEPROM or something like that.

Assuming that's the case here, my other part of question remains - is
this property of SoC or board? The buses (SPI, I2C) are properties of
boards, even though were incorrectly put here. If the board has multiple
ethernets, the final ordering is the property of the board, not SoC. I
would assume that bootloader also configures the MAC address based on
the board config, not per SoC...

Best regards,
Krzysztof