Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Nov 2022 16:46:41 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     richardcochran@gmail.com, bagasdotme@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v3] net: ethernet: Simplify bool conversion
Message-ID: <Y2Uz4Sea8xekgpyR@lunn.ch>
References: <20221104063731.84008-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221104063731.84008-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Fri, Nov 04, 2022 at 02:37:31PM +0800, Yang Li wrote:
> The result of 'scaled_ppm < 0' is Boolean, and the question mark
> expression is redundant, remove it to clear the below warning:
> 
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> 
> change in v3:
> --According to Richard's suggestion, to preserve reverse Christmas tree order.

Don't send a new version of a patch for at least 24 hours.

https://docs.kernel.org/process/maintainer-netdev.html#tl-dr

People need time to review your patch and suggest how to make it
better.

	Andrew