Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eeae06d7-75b9-829e-21a0-0c2b087368d5@nvidia.com>
Date:   Fri, 4 Nov 2022 16:01:48 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout
 bounds
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mikko Perttunen <cyndis@kapsi.fi>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Ashish Mhetre <amhetre@nvidia.com>,
        Sameer Pujar <spujar@nvidia.com>,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220920081203.3237744-1-cyndis@kapsi.fi>
 <20220920081203.3237744-2-cyndis@kapsi.fi> <Y1aP7kDi8cJUTcGN@orome>
 <ee3073ba-d621-8b02-c986-3cf44cfbba96@nvidia.com>
 <b9b20abc-d37f-f74a-a416-2e210bf944c4@linaro.org>
 <3a783b8d-4970-663f-816a-15aad5a66a48@nvidia.com>
 <a72c0e60-732f-3486-722e-851f21ebe640@linaro.org>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <a72c0e60-732f-3486-722e-851f21ebe640@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVhHN2RNT2JsV1RnOWRmeFVycE5RZ1VIU3ZDVjdFWDJMNzhTWFR3Wmw2dnlj?=
 =?utf-8?B?aEZOVTVQSEJMYm1ZeUZaNk54NjYwbytEdldTMXNpT1FJY1dVMHVUTSs5U0do?=
 =?utf-8?B?by9Kanp2d01BajdnWEVqbHZyd29qWWpnVGtsbE9rbnVPVnE0d1Nrd1dYWUpv?=
 =?utf-8?B?bmtjYmVCemtjMloxNVRidUxkdGhYbGlWN20rc0lwNVlMYXRod1djRThwdXlk?=
 =?utf-8?B?Uitpa0tVL202SmllVnp4YnBEclR4Y0xoZXFWU29BUXhPQmt0MFNoVWM0S3Vt?=
 =?utf-8?B?cndhaW5UNHRmMUFsUjB5Rk9JTEovZjJ6c0hnWkxUM29FV3Uzd3ZUanVnbEMy?=
 =?utf-8?B?V3kyaWFWRzZiZzQyS0Y3MDhpZTlHWjNFY2JTOGNiNklFNmdGUUJIaFo5Tkpz?=
 =?utf-8?B?akpLeE1Hc0NRV2xYQjVUQVc0QVhERmFRa1gzYTlnTFlTbFdZa2pJOVpucW1j?=
 =?utf-8?B?L3RIWUN0eFhGL0E1SW9WUlFDMHNBOThTZVlwb3dNdzA5TnF1QTB5ZlB4cEtz?=
 =?utf-8?B?eUI2VW4vNkJvMHJWWFprMXRlbXhBdzFOWUlKMnBGLzR3bFNYa3QvemRJSDhp?=
 =?utf-8?B?d2FrN0NBS2NxQUFsTUFhcjh2V0lHNEM3bXJGWjdtWEpteGlqYWVLenU2WTNS?=
 =?utf-8?B?Q2k4NzZoQW5TaFNCa2w2SW1WV3FPVzJPRWtwVXhmK1dWcWZVUnJ1ZS83Q0My?=
 =?utf-8?B?WmVRRW1RTlEyQi9vRzkrYXRrdHR0bFk3L3RIcngwYndBcW5EZDFxOUc5aEtJ?=
 =?utf-8?B?L2h1ZG9pM3laanhBeWNyOGE5TDZBUlVoMGwxOUhianlDS3pMS2M0S0Zwb2d3?=
 =?utf-8?B?TjZpOXZpSzRuWkVHRWhpVDB3N2oxelNXbFdRcUNKR2VKSkhVYXFlcVlnbTZB?=
 =?utf-8?B?b24yWUZnS3J4MWFIK1VhMDJaYjJOT2xqZDF4QkVmQVp2cUdtUklTb1BaclhJ?=
 =?utf-8?B?dUM4TURqQUs3NVlIRmk5UDBKV2l1UUc4dFp4aVVsVWZYTklsTmdjbXltWnRx?=
 =?utf-8?B?Y1B2THVML2h6MVZmYlVoa1JDTWxzb0ZTUEhPaTlKY3M0REF6YlNEZElDaG90?=
 =?utf-8?B?bHVuS3FPQUFlZFd1cVIvdi9HNVg3dGltbWxpSnRoNkx1ZkVRUFFZbkhFMmhH?=
 =?utf-8?B?WGVEOWhxcFE5SGRNRUdPM2d1NHl1cEQxeHMyQmNYNGdwbVBtaU9MS0ZMR2pp?=
 =?utf-8?B?SHMyVTNkUmpFcFVOSHppN0RNNXJLb3l3cGJXSkNKYlNaS2ROWDhoRk9QMlpr?=
 =?utf-8?B?NUxBQXdLUXJQelE5SUhTSW1wNVhmZlVZUzNTUlRIbkRxQTk3R25FNHhRMXBX?=
 =?utf-8?B?d2Fwekk1SmZRRHd2UnJTTlpWb1NpUkgySXpMSkpJd2JmaU1Vd1k0eERhSGFy?=
 =?utf-8?B?L0lsYVBJWEVnclJPVzFyYkphYUh3aVNyUnBpLzFKNFBkcDI0bWxYV095K2hp?=
 =?utf-8?B?dWpoandvai8wakxHd0tXQzVVaXlIYWNabzNSQUpLSnBDN1ZFQmFtT1VaOXM2?=
 =?utf-8?B?Q3EwQlZpRytVaGdtcUxVZC8xZ0hEcnpuRFlTbjhqNnpTN2FwRkt5VTEvMXZZ?=
 =?utf-8?B?bWhZTVdCUVJnM292Y0lzNW5Va3hwZmVpakw3dUtsK1lQZzNRdHNJQlUwajdB?=
 =?utf-8?B?OEFmL1daL3c1aWxWZVJDSUJib1Qxb001R2pZV1ZDYkV6RFhWNlo2OW1KaVRm?=
 =?utf-8?B?WHBxanpCWFNpTE9XNFViTmRzOU5ZZmJ6b0tDaUora3FnTGFsa0k3SDRyYjVS?=
 =?utf-8?B?UjQ0TzdLNExqcVFqLzAxanorTzM3N2hxRTI5Z3FvSmV2bCtUQ0Y4Qi96THZZ?=
 =?utf-8?B?alkrcHRaL0tUVXkySEdSWEtVYWp6YnM0SHFRUXN2NkZLcHVHS3ppVEJXalB1?=
 =?utf-8?B?bDA3MGw0ZURpVThXK3dsNDU4NXRuUE1JTHZNbUFwU3F6d1l5K2JxZ0dpdDho?=
 =?utf-8?B?SGVKRXYxWUgrL1dhdGJmWnZVWjJndGU0bHN5ZHN0aThGV1ZTZG5uZWlzRHhY?=
 =?utf-8?B?Si9mNFJEcXdsU3N5Rk1oODFDL0kxRjhBU3JqY2kxamxlbENINDc0MWJDSE14?=
 =?utf-8?B?a3R1blFaNjJ0RjhiUktTU2NuZ3BlVEh3VlNkN2tGOXAwYnEvTTNVTElRUHha?=
 =?utf-8?B?NmhoSVRuZ2kwREZQYUluUThZSitVemhwRk9DZ3NobjhyMXRDS0NzTU5mT1dF?=
 =?utf-8?B?UW1xQzRaVmdvamtLWi9BTndxLzlJb3JYT2ZLaG1xa2pEK2E0N0owVU5obW1j?=
 =?utf-8?B?QWl6aEpSdjJtOU0vV3J3L2s1aE5BPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24e0d02e-a907-4db8-fd5f-08dabe7de5a3
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:01:56.2077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uc5lW2Qh+UFLDM0P06wBoHlYENHuNENLwJcjhqWz+Q9i7HKoNdleTkL17MHKRbLIvqdid7Ks/8nv/9xSjqnueA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5275
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 04/11/2022 15:48, Krzysztof Kozlowski wrote:
> On 04/11/2022 11:46, Jon Hunter wrote:
>>
>> On 04/11/2022 15:35, Krzysztof Kozlowski wrote:
>>> On 04/11/2022 11:33, Jon Hunter wrote:
>>>> Hi Thierry, Krzysztof,
>>>>
>>>> On 24/10/2022 14:15, Thierry Reding wrote:
>>>>> On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote:
>>>>>> From: Mikko Perttunen <mperttunen@nvidia.com>
>>>>>>
>>>>>> On Tegra234 NVDEC firmware is loaded from a secure carveout, where it
>>>>>> has been loaded by a bootloader. When booting NVDEC, we need to tell it
>>>>>> the address of this firmware, which we can determine by checking the
>>>>>> starting address of the carveout. As such, add an MC API to query the
>>>>>> bounds of carveouts, and add related information on Tegra234.
>>>>>>
>>>>>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>>>>>> ---
>>>>>> v2:
>>>>>> - Add check for 64-bit phys_addr_t. In practice phys_addr_t
>>>>>>      is always 64 bits where this runs, but it avoids warnings in
>>>>>>      compile test.
>>>>>> ---
>>>>>>     drivers/memory/tegra/mc.c       | 25 +++++++++++++++++++++++++
>>>>>>     drivers/memory/tegra/tegra234.c |  5 +++++
>>>>>>     include/soc/tegra/mc.h          | 11 +++++++++++
>>>>>>     3 files changed, 41 insertions(+)
>>>>>
>>>>> Krzysztof,
>>>>>
>>>>> I've applied this to the same tree as the patch that uses it for now.
>>>>> Let me know if you want me to put this on a separate stable branch for
>>>>> you to pull in.
>>>>
>>>> Any update on this?
>>>
>>> What kind of update do you expect?
>>
>> Ha! I guess I should be more explicit :-)
>>
>> Well, I would like to see this change in -next and so I was hoping that
>> you would respond to the above to indicate how you would like to pull
>> this in.
> 
> The change will be in next via Thierry. I do not have to pull this in.
> 
> The maintainer which applies patches is responsible for:
> 1. Having his tree in linux-next,
> 2. Sending the patches to upstream maintainer (e.g. arm-soc, Linus)
> later in pull request.
> 
> There is no job for me here, if I agree with Thierry. There would be a
> job if I needed a separate stable branch, but that I did not decide
> yet... Do you think I need to pull it? If so, why?


No. Like I said I just want to get this into -next for testing. I had 
_wrongly_ assumed that Thierry was waiting on feedback from you. I see 
this is not the case and so let me check with Thierry where this is.

Jon

-- 
nvpublic