Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <af0d6881-76c0-f570-0c5b-f664e261c4cf@digikod.net>
Date:   Fri, 4 Nov 2022 18:03:53 +0100
MIME-Version: 1.0
User-Agent: 
Subject: Re: [BUG] blacklist: Problem blacklisting hash (-13) during boot
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <thomas@t-8ch.de>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        David Howells <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>, keyrings@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Mark Pearson <markpearson@lenovo.com>,
        keyrings@vger.kernel.org,
        linux-security-module <linux-security-module@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>
References: <c8c65713-5cda-43ad-8018-20f2e32e4432@t-8ch.de>
From:   =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>
In-Reply-To: <c8c65713-5cda-43ad-8018-20f2e32e4432@t-8ch.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

Thanks for this report. These error messages seem correct but I don't 
see any legitimate reason for the firmware to store duplicate 
blacklisted hashes.

According to the blacklist_init() function, the "blacklisting failed" 
message could be improved to explain that only a set of hashes failed, 
and why they failed. However, despite this message, this should work as 
expected and should not generate any issue.

Did you contact Lenovo to report this issue (i.e. duplicate hashes in 
their firmware)?

Could you please provide the list of duplicate hashes?

Regards,
  Mickaël


On 15/10/2022 05:16, Thomas Weißschuh wrote:
> Hi,
> 
> Since 5.19 during boot I see lots of the following entries in dmesg:
> 
> blacklist: Problem blacklisting hash (-13)
> 
> This happens because the firmware contains duplicate blacklist entries.
> As commit 6364d106e041 [0] modified the "blacklist" keyring to reject updates
> this now leads to the spurious error messages.
> 
> The machine is a Thinkpad X1 Cargon Gen9 with BIOS revision 1.56 and firmware
> revision 1.33.
> 
> [0] 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring")