Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/mixed; boundary="------------N0gS0AJ0YtPQ46c7sxUVmRvK"
Message-ID: <11ccd37a-fa33-2d43-619d-e82df23708b8@intel.com>
Date:   Fri, 4 Nov 2022 10:29:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 01/10] x86/Kconfig: enable X86_X2APIC by default and
 improve help text
Content-Language: en-US
To:     "Elliott, Robert (Servers)" <elliott@hpe.com>,
        =?UTF-8?Q?Mateusz_Jo=c5=84czyk?= <mat.jonczyk@o2.pl>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>
References: <20220911084711.13694-1-mat.jonczyk@o2.pl>
 <20220911084711.13694-2-mat.jonczyk@o2.pl>
 <MW5PR84MB18424DF86AE0D9B60994A38BAB339@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
 <94f56ba4-2ee1-581b-36b9-98d59a978354@intel.com>
 <DM4PR84MB185539050D426BFA8EFAC36BAB389@DM4PR84MB1855.NAMPRD84.PROD.OUTLOOK.COM>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <DM4PR84MB185539050D426BFA8EFAC36BAB389@DM4PR84MB1855.NAMPRD84.PROD.OUTLOOK.COM>
Precedence: bulk

This is a multi-part message in MIME format.
--------------N0gS0AJ0YtPQ46c7sxUVmRvK
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 11/3/22 16:41, Elliott, Robert (Servers) wrote:
> How are the defconfig files supposed to keep up with valid
> combinations of options?

On some level, it doesn't matter as long as "make defconfig" and the
Kconfig rules result in something generally sane.

> Despite its filename, arch/x86/configs/x86_64_defconfig does not even have:
>   CONFIG_X86_64=y
> which enables many options. That was added by:
>   commit 622e3f28e50f ("x86: 64-bit defconfig remake")
>   Sun May 4 19:57:19 2008 +0400 
> but removed by:
>   commit 8b1bb90701f9a51f ("defconfig reduction")
>   Sat Aug 14 22:05:58 2010 +0200
> 
> It does have
>   CONFIG_SMP=y
> 
> which should imply X86_LOCAL_APIC, but that's missing too.
> 
> It does have 
>   CONFIG_HYPERVISOR_GUEST=y
> so doesn't need IRQ_REMAP to enable X86_X2APIC.

It sounds like folks generally want the defconfig files to have minimal
contents.  CONFIG_X86_64 isn't in there because it's not _needed_.

So, if the attached patch results in:

$ rm .config
$ make defconfig
$ grep X86_X2APIC .config
CONFIG_X86_X2APIC=y

Is there really anything else we need?  Kconfig seems to have figured
everything out just fine and without any complaints.
--------------N0gS0AJ0YtPQ46c7sxUVmRvK
Content-Type: text/x-patch; charset=UTF-8; name="x64-defconfig.patch"
Content-Disposition: attachment; filename="x64-defconfig.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2FyY2gveDg2L2NvbmZpZ3MveDg2XzY0X2RlZmNvbmZpZyBiL2FyY2gv
eDg2L2NvbmZpZ3MveDg2XzY0X2RlZmNvbmZpZwppbmRleCA2OTc4NDUwNWE3YTguLjhjY2Nk
YTJhODljOSAxMDA2NDQKLS0tIGEvYXJjaC94ODYvY29uZmlncy94ODZfNjRfZGVmY29uZmln
CisrKyBiL2FyY2gveDg2L2NvbmZpZ3MveDg2XzY0X2RlZmNvbmZpZwpAQCAtMzAsNiArMzAs
NyBAQCBDT05GSUdfS0FMTFNZTVNfQUxMPXkKIENPTkZJR19QUk9GSUxJTkc9eQogQ09ORklH
X1NNUD15CiBDT05GSUdfSFlQRVJWSVNPUl9HVUVTVD15CitDT05GSUdfWDg2X1gyQVBJQz15
CiBDT05GSUdfUEFSQVZJUlQ9eQogQ09ORklHX1g4Nl9SRVJPVVRFX0ZPUl9CUk9LRU5fQk9P
VF9JUlFTPXkKIENPTkZJR19NSUNST0NPREVfQU1EPXkK

--------------N0gS0AJ0YtPQ46c7sxUVmRvK--