Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Nov 2022 14:54:50 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-nilfs@vger.kernel.org
Subject: Re: [RFC][PATCH v3 28/33] timers: fs/nilfs2: Use
 timer_shutdown_sync() before freeing timer
Message-ID: <20221104145450.7944d825@rorschach.local.home>
In-Reply-To: <CAKFNMomoVn3Zj5xaH6hjXHO+KXj983yZEue5Jx4wH+_m5NiJjA@mail.gmail.com>
References: <20221104054053.431922658@goodmis.org>
        <20221104054917.009383303@goodmis.org>
        <CAKFNMomoVn3Zj5xaH6hjXHO+KXj983yZEue5Jx4wH+_m5NiJjA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 4 Nov 2022 15:57:04 +0900
Ryusuke Konishi <konishi.ryusuke@gmail.com> wrote:

> On Fri, Nov 4, 2022 at 2:48 PM Steven Rostedt wrote:
> >
> > From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> >
> > Before a timer is freed, timer_shutdown_sync() must be called.
> >
> > Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/
> >
> > Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> > Cc: linux-nilfs@vger.kernel.org
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> > ---
> >  fs/nilfs2/segment.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
> > index b4cebad21b48..c50dc377da26 100644
> > --- a/fs/nilfs2/segment.c
> > +++ b/fs/nilfs2/segment.c
> > @@ -2752,7 +2752,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci)
> >
> >         down_write(&nilfs->ns_segctor_sem);
> >
> > -       del_timer_sync(&sci->sc_timer);
> > +       timer_shutdown_sync(&sci->sc_timer);
> >         kfree(sci);
> >  }
> >
> > --
> > 2.35.1  
> 
> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> 
> This is the second time, but my Ack is not tagged, so I'll reply again
> just in case.
>

Thanks. I might have missed it, but I also changed the name, and wanted
to make sure everyone saw that ;-)

-- Steve