Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1305593rwl; Fri, 4 Nov 2022 12:15:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4I2mvE9m8eYUgBtZq33T5YVQ9JkMA/v2EhLDJC1ZYjlTPPJ7zW5UpxH25gAmm8Cq2tfY36 X-Received: by 2002:a17:907:b602:b0:7ad:e82c:3355 with SMTP id vl2-20020a170907b60200b007ade82c3355mr22683321ejc.3.1667589343884; Fri, 04 Nov 2022 12:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667589343; cv=none; d=google.com; s=arc-20160816; b=eIkr5OiiU8tRw23vgQdH4xGyNUZJjJxv1H2cz9BGpwka7CHRHX5Ul+5R5nt0BoJTqi FxbZWPBPgFlRbPR+vHOhuICBO0jBTqKpyCbodarJI+FKyVPzB5boE1tkR9ZOVbxG6XnT Klp+XX8JlHdTFCMwCCQXQotziTDq0GvousQNNW9vaCinRR9/8aZVRtWnSiFVHV4sPxsp NTtWBM1tMsR71pXH7eyljRNi3U/zbNqCkN6bQu7iV2DIdw7tEYdyyO1o3Ifg7UKUAaOp Ge6zcX6ypgVdCPJnQJafuP8zC9HO4CMz264b9qcyjAqdyj7NRsRYrg9oheTg69EGQ0F7 iixg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0k+a9LphvaL77RGrRIZieknkLWUANsqr9WzTp/ltIgs=; b=aJx+DhljvwXgIqFlCsgXu8eIdEOiFyT8MGEQe4WC37Q81ozm9eGUg3nVOS8qqiaKZk 6FQw0GVZgAqZQWcCzBQaSv/2Y8TnGHpuz4o7iBd/zdofO7LM5KwHPrkhSsKQICkMnSvv e+xfv94vzVfOoFZTG5EwEbi1XUaXAvAk4faI30kmkEIkLyPOlDYDnDW02qTN6TPskr01 mll2hv+8GoJ9KEr9C8JtCNS7pTVIzjwUrbC13LKQzewgb4qJH9W+bF3a5eZFhf6xGplb jezsm0T3IDvbu6dBhoiB4GlJvetBRpDsMZBPBMQipRZrM9C3E2KMOd+HUhqafXUzqjsp Uh4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=df2W3F78; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020aa7dd19000000b0046054d6b3a8si249630edv.302.2022.11.04.12.15.20; Fri, 04 Nov 2022 12:15:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=df2W3F78; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiKDSsx (ORCPT + 96 others); Fri, 4 Nov 2022 14:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiKDSso (ORCPT ); Fri, 4 Nov 2022 14:48:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24EA52F00F; Fri, 4 Nov 2022 11:48:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 825616230C; Fri, 4 Nov 2022 18:48:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AA7EC4314D; Fri, 4 Nov 2022 18:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667587719; bh=YOVWBfQa9OqvYyzMeQsD63kY8dwF5YGLRC4BmattvKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=df2W3F78KU5UBALZZavDtPxzF+vCEteePbZhFvW0Fh1bVzjyBa3PX35mGORzHRDOR Sm5i2CWm6nGpKIGJLZTAjg/dnwQVclIOlScOU1l2NLASlJlQ0J8xgV6CoBkXfOMHk9 en4bza+d9gNDUx7TNYp8KTKUHri/Sj7AK9M2TtrG3+/VfEfcXxxnIwUlyG6+d5HwI+ wU7EHfn3jZqAT2QswLhmjqaO4nJVpgyEXcWKJqXXsT7fgbUQ88wR7fw461VyXHjpbM mgcKXIBy2aR018x5Bn8JcL0h9xAvZhfbrYMW5DlbHUnnaUKxQNOFac8wVGIasusYF+ ej7hZdc511TBw== Date: Fri, 4 Nov 2022 11:48:38 -0700 From: Jakub Kicinski To: Tang Bin Cc: jiawenwu@trustnetic.com, mengyuanlou@net-swift.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: libwx: Remove variable dev to simplify code Message-ID: <20221104114838.4ca54ea2@kernel.org> In-Reply-To: <20221103071956.17480-1-tangbin@cmss.chinamobile.com> References: <20221103071956.17480-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Nov 2022 15:19:56 +0800 Tang Bin wrote: > In the function wx_get_pcie_msix_counts(), the variable dev > is redundant, so remove it. This patch doesn't make any difference. Please consider not sending similar patches to netdev.