Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1335296rwl; Fri, 4 Nov 2022 12:39:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5xKcu6RPo+LhFVA2hxrhvdtKjw5McFzzL/gnF2oQglF/Ke70LT81HCQI2MajM/JE7FU9dt X-Received: by 2002:a17:906:2a93:b0:78d:b87e:6aab with SMTP id l19-20020a1709062a9300b0078db87e6aabmr36250823eje.157.1667590765480; Fri, 04 Nov 2022 12:39:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667590765; cv=none; d=google.com; s=arc-20160816; b=gkrqTSF1PV/O8rACGKhcyiREWiXX1SJHP+DdD1rbSnYnEA2Dw7Nnk2B9Wj3iQsBZi1 293DMSb7/C6m1ypoB95HNq7kNrEaYRX+k5nIrJeGIInA+bfMr3mBp3ubHrb5UnS0aI3T w3sjUX/BC7gCJ8kDgWZQa4U+aidrtRPV+hHcduA+yTMwfEpjsaOFWEHLNCzeB5e5mrFb r4fV11rsQX4JcIBNTugsquHWd8MLsSQwBxoVwkwbtZuoREcovuE99m6vkjANfa2fGhYg nCi3nn5KVq7H5x0GKwaJnAF8CUgtjbzVAPBBnbNn+JbJl2Krq7ou0kbD0xRjXPUtAFt+ 9q4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=fyXj9x2FnB8ou4iAknt6J7rS1z6xYHJdFhwKCJ5M7ks=; b=V4pB/vsb2Yp7hrqkwrAleqJV7ZxBGAV+HFBHMJdd5P81tObXURlkqcbh0Odt12Bu4Y dSSVfHqdh6x1fjqoTD6ArO0ZmH0+cmRaVd8lGsEtPeUKeB+C/lmx/6KzK7w8Qyc/suys M4vNg9foLGlXeB4oNDd8i5hymmVdI9pF+50nM1hVDyCVuUAv3PILAULdpFjEr4Cq/5z7 Ivj9VDatrnJhZJnrKWhMYCG8XbpF9V5cqWI95G1Q0FbN7DbtIDeh3v/dp7ZX0AatKwSB jORixvNt8/v8ukWxK8r4Ep1AslQxfBXlUETl8iQ3vFhzvJULD+gqIa03djC/weYk93sW VZOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc31-20020a1709078a1f00b007a8beb3aa4csi6655408ejc.872.2022.11.04.12.39.02; Fri, 04 Nov 2022 12:39:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbiKDTCQ (ORCPT + 97 others); Fri, 4 Nov 2022 15:02:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbiKDTCO (ORCPT ); Fri, 4 Nov 2022 15:02:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A8743875 for ; Fri, 4 Nov 2022 12:02:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3FD61622CF for ; Fri, 4 Nov 2022 19:02:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25E15C433D6; Fri, 4 Nov 2022 19:02:12 +0000 (UTC) Date: Fri, 4 Nov 2022 15:02:10 -0400 From: Steven Rostedt To: Tvrtko Ursulin Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer Message-ID: <20221104150210.1b147688@rorschach.local.home> In-Reply-To: References: <20221104054053.431922658@goodmis.org> <20221104054914.271196777@goodmis.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Nov 2022 08:48:28 +0000 Tvrtko Ursulin wrote: > If it stays all DRM drivers in one patch then I guess it needs to go via > drm-misc, which for i915 would be okay I think in this case since patch > is extremely unlikely to clash with anything. Or split it up per driver > and then we can handle it in drm-intel-next once core functionality is in. > > We do however have some more calls to del_timer_sync, where freeing is > perhaps not immediately next to the site in code, but things definitely > get freed like on module unload. Would we need to convert all of them to > avoid some, presumably new, warnings? I'm happy to split this patch up. I just got a bit lazy and started just grouping via entire subsystems. You should see the networking patch ;-) -- Steve