Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <20221104064055.2.I49b25b9bda9430fc7ea21e5a708ca5a0aced2798@changeid>
References: <20221104064055.1.I00a0e4564a25489e85328ec41636497775627564@changeid>
 <20221104064055.2.I49b25b9bda9430fc7ea21e5a708ca5a0aced2798@changeid>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date:   Fri, 4 Nov 2022 14:19:47 -0700
Message-ID: <CAE-0n53FLz+4XROL7t5Vk1pEgvAX4tJYO4UK8rdCQUW0Pq78jg@mail.gmail.com>
Subject: Re: [PATCH 2/3] clk: qcom: lpass-sc7180: Fix pm_runtime usage
To:     Bjorn Andersson <andersson@kernel.org>,
        Douglas Anderson <dianders@chromium.org>
Cc:     Taniya Das <quic_tdas@quicinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Judy Hsiao <judyhsiao@chromium.org>,
        Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Douglas Anderson (2022-11-04 06:56:29)
> The sc7180 lpass clock controller's pm_runtime usage wasn't broken
> quite as spectacularly as the sc7280's pm_runtime usage, but it was
> still broken. Putting some printouts in at boot showed me this (with
> serial console enabled, which makes the prints slow and thus changes
> timing):
>   [    3.109951] DOUG: my_pm_clk_resume, usage=1
>   [    3.114767] DOUG: my_pm_clk_resume, usage=1
>   [    3.664443] DOUG: my_pm_clk_suspend, usage=0
>   [    3.897566] DOUG: my_pm_clk_suspend, usage=0
>   [    3.910137] DOUG: my_pm_clk_resume, usage=1
>   [    3.923217] DOUG: my_pm_clk_resume, usage=0
>   [    4.440116] DOUG: my_pm_clk_suspend, usage=-1
>   [    4.444982] DOUG: my_pm_clk_suspend, usage=0
>   [   14.170501] DOUG: my_pm_clk_resume, usage=1
>   [   14.176245] DOUG: my_pm_clk_resume, usage=0
>
> ...or this w/out serial console:
>   [    0.556139] DOUG: my_pm_clk_resume, usage=1
>   [    0.556279] DOUG: my_pm_clk_resume, usage=1
>   [    1.058422] DOUG: my_pm_clk_suspend, usage=-1
>   [    1.058464] DOUG: my_pm_clk_suspend, usage=0
>   [    1.186250] DOUG: my_pm_clk_resume, usage=1
>   [    1.186292] DOUG: my_pm_clk_resume, usage=0
>   [    1.731536] DOUG: my_pm_clk_suspend, usage=-1
>   [    1.731557] DOUG: my_pm_clk_suspend, usage=0
>   [   10.288910] DOUG: my_pm_clk_resume, usage=1
>   [   10.289496] DOUG: my_pm_clk_resume, usage=0
>
> It seems to be doing roughly the right sequence of calls, but just
> like with sc7280 this is more by luck than anything. Having a usage of
> -1 is just not OK.
>
> Let's fix this like we did with sc7280.

Any Fixes tag?

>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>