Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1544864rwl; Fri, 4 Nov 2022 15:40:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4UuOH2B61lzx6S+Y6KYA46BmuEYbfklSGmLN8qJ+/woIy5onAkznJ+SkhvDi9NYc8ssOTq X-Received: by 2002:a05:6a00:993:b0:56c:80f6:db5 with SMTP id u19-20020a056a00099300b0056c80f60db5mr37594239pfg.45.1667601653478; Fri, 04 Nov 2022 15:40:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667601653; cv=none; d=google.com; s=arc-20160816; b=kEazreC9zROKRyEcGEx5pikV0GbmuTn4TmKO2InhFh5p9CZM9RKcOZG1UL/YGIL3Dx j4E7taGnldGuQcDeGSLXyA48vaEB2IxhMb9rAzYzhi5rJ0tISyQZ6j1HSVaw624arkdu 5BNMEbSC9NeRW4dClEvi/sJb9NlcVPpGZ//br+3axhOSm7W88qSbFq/wt90xXZ0Y0Yod zRPuteHVQze11fn3mF25Pd//w2Hzher1N1igLjg0GSwfBuRR+uMjXh5ANPFt//UHleMf Rf2CwP5K7FUTA4BgOE4RvqHFhYCMmAvKTZvDbng4k/7rCs6uLTNoLa+9RTGQ35qf6wz8 2rhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ecezFjV64/LD06J6jguRRXZl22Q3tcFx+db0PLVvgdI=; b=h14z9vEh59TXUQcsE+h+f3D2fX8wK7Uayl0rf9Yn6Z3DOqkYY9I2d2BAjoLw3axODz g8C7zM37oiGM0UYiDXUf+sJLht1RXZAi3JUg/s9LviN5XQcaEnofaF6GrJ4bQkEb2SBu 7Y9SpHiPwZDooKrv6cUnOZD9H8ODJ56cC0Sm7nWgrvm5XZqNyZhqsMsd46zceHhl6oam EHUqkxkj3V+zz2SPmFWv5mx8HcNCqHEAWw1BoICdh+XaN/Q0+vt/iT0E+nqp+wPao2u3 8qYuuzYG8SgKSCE0EdesAFn/bQR1SYhZW262gkT7UPv1o1tTE1nvE2gJX229lnQtSqEA 6qsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=qJ9EzN5E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p13-20020a170902e74d00b001786b70f913si928596plf.164.2022.11.04.15.40.41; Fri, 04 Nov 2022 15:40:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=qJ9EzN5E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbiKDWO3 (ORCPT + 97 others); Fri, 4 Nov 2022 18:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiKDWO1 (ORCPT ); Fri, 4 Nov 2022 18:14:27 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F011429B8; Fri, 4 Nov 2022 15:14:26 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7a4329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7a4:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A8D821EC02DD; Fri, 4 Nov 2022 23:14:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667600064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ecezFjV64/LD06J6jguRRXZl22Q3tcFx+db0PLVvgdI=; b=qJ9EzN5E1tRwW+/5g4DykyP+6H7FDc8rEd4+5XkwNMX7Ge9cskSIhebAZcuEXBsFPSDrdZ V2+9hv+kpnXecyKREX149KhAAmic9mpikaoE5CatmsWroS8HFQ47mbqeWFvVYRSjzfI15A BYJrMhT38FkgH3McnP3Qaa5HQHZz1A4= Date: Fri, 4 Nov 2022 23:14:24 +0100 From: Borislav Petkov To: "Joseph, Jithu" Cc: hdegoede@redhat.com, markgross@kernel.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org, ashok.raj@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, thiago.macieira@intel.com, athenas.jimenez.gonzalez@intel.com Subject: Re: [PATCH 07/14] x86/microcode/intel: Expose microcode_sanity_check() Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221021203413.1220137-8-jithu.joseph@intel.com> <4ee6073a-461e-562d-5c00-d1b371288b63@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4ee6073a-461e-562d-5c00-d1b371288b63@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2022 at 03:02:42PM -0700, Joseph, Jithu wrote: > Wanted to check with you, if it is okay to rename the first "reserved" > field in microcode_header_intel to "metasize" today (as shown in the > diff below) or would you prefer to do that too at a later point ? > (doing so today will help to avoid redefining an IFS specific header > struct, with this as the only change ) No objections - it is not used by the microcode loader anyway. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette