Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1616648rwl; Fri, 4 Nov 2022 16:46:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Ai9CBH+h8/ungkar6XH0tf+BVvMngkOH1CGN/1Ic79Y0Ct9EHEXztra09c4iWY/h5fm7k X-Received: by 2002:a05:6402:2319:b0:45c:4231:de18 with SMTP id l25-20020a056402231900b0045c4231de18mr38508098eda.383.1667605570137; Fri, 04 Nov 2022 16:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667605570; cv=none; d=google.com; s=arc-20160816; b=Hm9cfR8wSBxHNi3VqtJpyQgque3tWACmZ0TR/JO+B+X20DCrSSHvRwCObgmZ+OLc4h O3WTIGRHWk3XPZdiDz4jBmuiJtEdNcPBVBJvRzgb7nNmK+1lQMS+8KFQItQZu/oT5gOM X+fUSFut2HUzXyYuNW9Wtf/6SkvEgsjzetiWS+TYUhGywMf3XZ9gR2g+IIPX48gVoUI4 ebk8A1DwDomZ2jERaOOvSiWvxH9nTk/PA9mWKN25FL1yv6LBARG3kKCP3JVljq1ocmFF OqArFBdnO3MBKNSJbLiQJezaKmOdPGJhFqv5iT8iUpwzHdqRSbxM2A0zvktN/gjKmYQO yQHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QuilHsL7SZaLI6I/9kLeHsdX6pB2YA5K0ba/YI1xqGU=; b=ak0RrgeN9rC0gpv+8geRJX1S3ytl69VRlq23GpxgE+vBgkMws1IThb59Mf7mvVPb/R KDaYT+o7ks3P/bHrHwHUeYbBCQB6NVawyYSidwXO3Yb+wVlen56l9KbfoJxkRaXwPGDh 674AXEKOrvleydfq6oAHJbtdTDVkt6+3fBpJhQfV2OPJipxD5uDpaiLLlhxGFLYdl9KJ x4p76n0ZFTq01WQLRAsqskKXQvmN3YfUqSmhkmnLxm+TVFp05Dv37cQhse5SVrDgxM9W 2TFzG2S1KY4GcwVJAhbhAmDdOpaF3er8uFLuG9n6bf2YE9Jb4w7ebH7YjIvydIhHfO1y WJMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=MMYgUpIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id la26-20020a170907781a00b007a8dddc7ec8si359013ejc.382.2022.11.04.16.45.47; Fri, 04 Nov 2022 16:46:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=MMYgUpIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbiKDXgp (ORCPT + 97 others); Fri, 4 Nov 2022 19:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiKDXgo (ORCPT ); Fri, 4 Nov 2022 19:36:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F80B2F665 for ; Fri, 4 Nov 2022 16:36:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF3CF6233C for ; Fri, 4 Nov 2022 23:36:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01D93C433C1; Fri, 4 Nov 2022 23:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667605001; bh=22T8ApIzd/4Wr/C49UU1NXC4Fpg7XFQ5s94T+J49igo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MMYgUpIu4xmcDoxdp/r1rTSl+kGHZxIXwg0zB3fjuNupncK8Yeu8R5ShGUdDKO/+L 58AwepgEZtcBjRoXziIzPZkqMDTO8tHYKkPZKCWRKOtxMD/a/YE1/yQzwDaF108kB1 /aPKNYF4JAL2/R6JB+sSz33RtaQvQhwgiUyyyPuY= Date: Fri, 4 Nov 2022 16:36:40 -0700 From: Andrew Morton To: Vasily Gorbik Cc: Muchun Song , Muchun Song , Mike Kravetz , Gerald Schaefer , Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h Message-Id: <20221104163640.2057b74c25d6076f64912891@linux-foundation.org> In-Reply-To: References: <71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Nov 2022 17:02:02 +0100 Vasily Gorbik wrote: > 42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP") is > just a one liner activating this feature and only present in linux-next > and s390 features branch targeting v6.2. So, if you don't want to have > > Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()") > > fine with me. But then just dropping Fixes tag is probably a better > option. I hope that won't prevent it from going into some v6.1-rcX. > > @Andrew > should I resend? or would you be so kind to drop Fixes tag and add Reviewed-by > without it? Thank you I retained the Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()") and added Muchun's Reviewed-by:, thanks.