Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i0ad843c9:Fastmail
Message-ID: <214ed3e0-5959-8fa7-8d66-196e33112cb0@sholland.org>
Date:   Fri, 4 Nov 2022 21:21:23 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Content-Language: en-US
To:     Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, wens@csie.org
Cc:     mripard@kernel.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, Merlijn Wajer <merlijn@wizzup.org>
References: <9f8a0fc3-1d9a-b271-3c26-4f7373b8a3e9@gmail.com>
From:   Samuel Holland <samuel@sholland.org>
Subject: Re: [BISECTED] Allwinner A33 tablet does not fully power off
In-Reply-To: <9f8a0fc3-1d9a-b271-3c26-4f7373b8a3e9@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Ivo,

On 10/29/22 10:23, Ivaylo Dimitrov wrote:
> After commit 843107498f91e57d1d4b22cd8787112726fdaeb4 (bus: sunxi-rsb:
> Implement suspend/resume/shutdown callbacks) Q8 A33 tablet I have here
> cannot be powered-on after power-off, it needs press-and-hold of the
> power button for 10 seconds (I guess some HW assisted power down
> happens) before it can be powered-on again.
> 
> The following patch makes it behave correctly:
> 
> diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
> index 60b082fe2ed0..30016d62044c 100644
> --- a/drivers/bus/sunxi-rsb.c
> +++ b/drivers/bus/sunxi-rsb.c
> @@ -818,10 +818,7 @@ static int sunxi_rsb_remove(struct platform_device
> *pdev)
> 
>  static void sunxi_rsb_shutdown(struct platform_device *pdev)
>  {
> -       struct sunxi_rsb *rsb = platform_get_drvdata(pdev);
> -
>         pm_runtime_disable(&pdev->dev);
> -       sunxi_rsb_hw_exit(rsb);
>  }
> 
>  static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = {
> 
> 
> I guess the issue comes from the fact that by the time 'power off'
> command to the power management IC has to be send, the bus it lives on
> is already down, so the device is left in semi-powered down state. Ofc
> this is a wild guess, however, preventing the bus being turned off on
> shutdown fixes the issue.

Your guess is correct. The controller gets shut down in

  kernel_power_off()
    kernel_shutdown_prepare()
      device_shutdown()

but the PMIC communication needs to happen later in

  kernel_power_off()
    machine_power_off()
      pm_power_off()

> Please LMK if the above is the correct approach so I will send a proper
> patch or something else shall be fixed.

Yes, this is exactly the right approach. The whole sunxi_rsb_shutdown()
function should be removed. When you send a patch, please add a Fixes:
tag referencing the commit that you bisected to.

Regards,
Samuel