Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i0ad843c9:Fastmail
Message-ID: <90fcb1bc-6388-d4ba-a9cd-c5d35fb27e74@sholland.org>
Date:   Fri, 4 Nov 2022 21:32:07 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Content-Language: en-US
To:     Bastian Germann <bage@debian.org>
Cc:     Vasily Khoruzhick <anarsoul@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
        Jernej Skrabec <jernej.skrabec@gmail.com>
References: <20221007234553.12328-1-bage@debian.org>
 <20221007234553.12328-2-bage@debian.org>
From:   Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
In-Reply-To: <20221007234553.12328-2-bage@debian.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Bastian,

Please make sure you include the sunxi platform maintainers (as reported
by get_maintainers.pl) when sending your patch, so it gets in our inboxes.

Subject prefix should be "arm64: dts: allwinner: a64:" (with "dts:").

On 10/7/22 18:45, Bastian Germann wrote:
> From: Vasily Khoruzhick <anarsoul@gmail.com>
> 
> Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
> and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
> The I2C controlling signals are connected to R_I2C bus.

Please remove this sentence; it doesn't make sense. The RTL8723CS does
not have any I2C connection.

> Enable it in the device tree.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pinebook.dts      | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> index 620cb3ef5f6c..19ba87c411ed 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> @@ -406,6 +406,19 @@ &uart0 {
>  	status = "okay";
>  };
>  
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> +	uart-has-rtscts;
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "realtek,rtl8723cs-bt";
> +		device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */

You also need:

		enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */

(this is BT-RST-N in the schematic).

The rest looks good to me.

Regards,
Samuel

> +		host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> +	};
> +};
> +
>  &usb_otg {
>  	dr_mode = "host";
>  };